Current Async TODOs

massover · May 13, 2020, 2:25pm

It looks like the StaticFilesHandlerMixin is missing the the async response function.

massover/asgi-runserver/blob/master/asgi_runserver/management/commands/runserver.py#L60



    try:
        return import_string(app_path)
    except ImportError as err:
        raise ImproperlyConfigured(
            "ASGI application '%s' could not be loaded; "
            "Error importing module." % app_path
        ) from err


class StaticFilesHandlerMixin(DjangoStaticFilesHandlerMixin):
    async def get_response_async(self, request):
        try:
            return self.serve(request)
        except Http404 as e:
            return response_for_exception(request, e)


class ASGIStaticFilesHandler(StaticFilesHandlerMixin, DjangoASGIStaticFilesHandler):
    pass

Without this, this is the traceback

Exception inside application: 'NoneType' object is not callable
Traceback (most recent call last):
  File ".../lib/python3.7/site-packages/daphne/cli.py", line 30, in asgi
    await self.app(scope, receive, send)
  File ".../src/django/django/contrib/staticfiles/handlers.py", line 86, in __call__
    return await super().__call__(scope, receive, send)
  File ".../src/django/django/core/handlers/asgi.py", line 161, in __call__
    response = await self.get_response_async(request)
  File ".../src/django/django/core/handlers/base.py", line 148, in get_response_async
    response = await self._middleware_chain(request)
TypeError: 'NoneType' object is not callable

I forgot to make it a pr to ask for a review on github. I’ll try and remember do that next time. Let me know if that seems right to you and it was just missing.

Topic		Replies	Views
Django async views Using Django	3	1033	September 21, 2021
Django 3.1 Async Article Show & Tell	1	795	August 4, 2020
Maybe it's just a blind spot, when it comes to async django Async	22	4676	May 5, 2024
Are concurrent database queries in ASGI a thing? Async/Channels	1	1004	October 5, 2023
Django Async ORM Show & Tell	1	1918	May 28, 2021

Current Async TODOs

Related topics