# need for clarification

**URL:** <https://forum.djangoproject.com/t/need-for-clarification/28887>\
**Category:** Django Internals\
**Created:** [March 9, 2024, 9:47am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887 "2024-03-09T09:47:23Z")\
**Posts on this page:** 7\
**Page:** 1

<div class="post-metadata">

**Author:** ![HamaBarhamou](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/hamabarhamou/32/18007_2.png) [@HamaBarhamou](https://forum.djangoproject.com/u/HamaBarhamou)\
**Post date:** [March 9, 2024, 9:47am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/1 "2024-03-09T09:47:23Z")

</div>

hi, sorry **sarahboyce** , **charettes** , **ngnpope** , **felixxm** to tag you but i really need to understand the implication of tiket [#34943](https://code.djangoproject.com/ticket/34943) on [#34277](https://code.djangoproject.com/ticket/34277). see also this [link](https://code.djangoproject.com/ticket/34943?action=diff&version=1)  
sorry for the inconvenience

---

<div class="post-metadata">

**Author:** ![sarahboyce](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/sarahboyce/32/12734_2.png) [@sarahboyce](https://forum.djangoproject.com/u/sarahboyce)\
**Post date:** [March 9, 2024, 10:30am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/2 "2024-03-09T10:30:15Z")

</div>

I think don’t worry.  
Cc yourself to the ticket so you get updates on it’s progress. If someone starts working on this before your PR lands, there will be some conflicts to resolve between the two, but it might not get picked up that quickly. 🤔

---

<div class="post-metadata">

**Author:** ![HamaBarhamou](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/hamabarhamou/32/18007_2.png) [@HamaBarhamou](https://forum.djangoproject.com/u/HamaBarhamou)\
**Post date:** [March 9, 2024, 11:01am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/3 "2024-03-09T11:01:57Z")

</div>

Thank you, **sarahboyce** ,

I wanted to thank you for your feedback. I am optimistic about completing my PR on time. However, my main concern is understanding the purpose from the moment **charettes** talks about regression. Would it be possible for my work on ticket 34277 to be merged at the end by the Django team?

---

<div class="post-metadata">

**Author:** ![sarahboyce](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/sarahboyce/32/12734_2.png) [@sarahboyce](https://forum.djangoproject.com/u/sarahboyce)\
**Post date:** [March 9, 2024, 11:06am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/4 "2024-03-09T11:06:32Z")

</div>

Sorry you need to be more specific. Where is there a discussion on regresion, can you link the comment you’re referring to?

And by “at the end”, what do you mean? At the end of what?

---

<div class="post-metadata">

**Author:** ![HamaBarhamou](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/hamabarhamou/32/18007_2.png) [@HamaBarhamou](https://forum.djangoproject.com/u/HamaBarhamou)\
**Post date:** [March 9, 2024, 11:13am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/5 "2024-03-09T11:13:36Z")

</div>

[here](https://code.djangoproject.com/ticket/34943)

> My recommendation would be to introduce a `unique_constraint: str | tuple[str | Expression]` kwarg and deprecate `unique_fields` . When provided a `str` it would be a reference to a `UniqueConstraint` by `.name` and when it’s a `tuple` it would be expected to be a index expression where `str` are resolved to field names.

by “at the end”, I mean the end of my contribution on 34277

---

<div class="post-metadata">

**Author:** ![sarahboyce](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/sarahboyce/32/12734_2.png) [@sarahboyce](https://forum.djangoproject.com/u/sarahboyce)\
**Post date:** [March 9, 2024, 11:21am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/6 "2024-03-09T11:21:37Z")

</div>

Alright still not quite sure what worries you.  
In that discussion he talks about “depreciation” (because changing the purpose and name of `unique_fields` is a breaking change).  
A “regression” would be a bug in the codebase introduced by a different code change.

Your contribution is done when it’s merged. It will get merged once it is “ready” to merge.  
As you have an accepted ticket, there’s no reason to believe it can’t be merged. More a process of reviews and revisions.

---

<div class="post-metadata">

**Author:** ![HamaBarhamou](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/hamabarhamou/32/18007_2.png) [@HamaBarhamou](https://forum.djangoproject.com/u/HamaBarhamou)\
**Post date:** [March 9, 2024, 11:31am UTC](https://forum.djangoproject.com/t/need-for-clarification/28887/7 "2024-03-09T11:31:08Z")

</div>

thank you for the clarification **sarahboyce** you are an angel.  
my whole problem was the word “depreciation” which i had apparently read as “regression”. now everything is in order in my head. sorry for the confusion 🥰.
