# Unsure of how to contribute to issue 32819

**URL:** <https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337>\
**Category:** Mentorship\
**Created:** [October 5, 2022, 6:31pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337 "2022-10-05T18:31:22Z")\
**Posts on this page:** 15\
**Page:** 1

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 5, 2022, 6:31pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/1 "2022-10-05T18:31:22Z")

</div>

Hello everyone,  
I would like to contribute to [this issue](https://code.djangoproject.com/ticket/32819), and I can see that a [pull request](https://github.com/django/django/pull/15246) is already open. I’m not sure about what steps are remaining to close this issue. Could anyone help me get started?  
@carltongibson - I would appreciate your input here 🙂

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 6, 2022, 8:40am UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/2 "2022-10-06T08:40:01Z")

</div>

Hi @nimra200 👋

OK, so that was dependent on the Forms changes we got in for Django 4.1. It **should** be good to go now.

First thing is to checkout locally and rebase on `main`. Make sure the changes make sense, review the tests, update the release notes and version changed annotations for Django 4.2 (i.e. `releases/4.2.txt` not `releases/4.1.txt`) and go through the conversation to see if there were any other left over points.

Does that get you going?

@smithdc1 was working on this but I know he’d be happy for you to pick it up, and would likely offer a word of input if you open a fresh PR.

---

<div class="post-metadata">

**Author:** ![smithdc1](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/smithdc1/32/23160_2.png) [@smithdc1](https://forum.djangoproject.com/u/smithdc1)\
**Post date:** [October 6, 2022, 12:51pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/3 "2022-10-06T12:51:10Z")

</div>

Hi 👋

Yes, do feel free to pick this up, I’ve not got capacity to look at this any time soon but will be able to provide some comments and guidance.

I think the discussion on the pr will highlight the remaining issues to resolve, in particular this series of comments. [Refs #32819 -- Added aria-describedby for help\_text. by smithdc1 · Pull Request #15246 · django/django · GitHub](https://github.com/django/django/pull/15246#discussion_r777873099). Likely that discussion can be continued on a fresh PR.

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 7, 2022, 2:52pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/4 "2022-10-07T14:52:29Z")

</div>

The first step I’m trying to do is checkout the PR locally.  
I tried `~/django-repo (main) $ git fetch origin pull/15246/head:ticket_32819` and got  
`fatal: couldn't find remote ref pull/15246/head`. I’m new to git and a little lost. I was following the directions here: [Checking out pull requests locally - GitHub Docs](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally)

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 7, 2022, 3:19pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/5 "2022-10-07T15:19:32Z")

</div>

Is `origin` `django/django` or your fork?

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 7, 2022, 3:44pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/6 "2022-10-07T15:44:38Z")

</div>

How can I check this?

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 7, 2022, 4:49pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/7 "2022-10-07T16:49:01Z")

</div>

e.g. in my shell now for `channels_redis`:

```auto
% git remote show origin
* remote origin
  Fetch URL: git@github.com:django/channels_redis.git
  Push URL: git@github.com:django/channels_redis.git
  HEAD branch: main
  Remote branches:
    1.x tracked
    2.0 tracked
    3.4.x tracked
    main tracked
  Local branches configured for 'git pull':
    main merges with remote main
    pubsub-test-hang merges with remote remove-async-generator
  Local ref configured for 'git push':
    main pushes to main (up to date)

```

You’re looking at the equivalent to this line to say `django/django` not ` `nimra200/django`:

```auto
  Fetch URL: git@github.com:django/channels_redis.git

```

Have a read here: [Git - Working with Remotes](https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes)

You need to add `django/django` as a remote, and pull the PR branch from there.

The GitHub docs are also very good: [Working with forks - GitHub Docs](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks)

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 11, 2022, 7:46am UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/8 "2022-10-11T07:46:27Z")

</div>

@nimra200 How did you get on here?

GitHub’s UI also has some GitHub specific options for checking out the PR if you’re still stuck…

 ![Screenshot 2022-10-11 at 09.45.32](https://us1.discourse-cdn.com/flex026/uploads/djangoproject/original/2X/c/c8602a4289cf0b32fe4c347a1fafedf56766c2dc.png)

---

<div class="post-metadata">

**Author:** ![ralphreid](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/ralphreid/32/10296_2.png) [@ralphreid](https://forum.djangoproject.com/u/ralphreid)\
**Post date:** [October 11, 2022, 8:08am UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/9 "2022-10-11T08:08:18Z")

</div>

Hi Carlton,  
Thanks. This is super cool and a feature I have not used. I will check it out.

Thanks.

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 11, 2022, 2:50pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/10 "2022-10-11T14:50:28Z")

</div>

Sorry, I hadn’t had a chance to look at this for a few days since we had a public holiday. I was able to checkout the PR locally with the github CLI!

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 11, 2022, 2:59pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/11 "2022-10-11T14:59:10Z")

</div>

I’m trying to rebase on `main` but I’m not sure what to do. I tried following this guide: [Working with Git and GitHub | Django documentation | Django](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/working-with-git/#rebasing-branches)  
I’m not sure what to do once I get to this point:

```auto
~/django (ticket_32819) $ git rebase --interactive main

hint: Waiting for your editor to close the file...

pick 73d519c879 Refs #32819 -- Added aria-describedby for help_text.

# Rebase f71b0cf769..73d519c879 onto f71b0cf769 (1 command)

#

# Commands:

# p, pick <commit> = use commit

# r, reword <commit> = use commit, but edit the commit message

# e, edit <commit> = use commit, but stop for amending

# s, squash <commit> = use commit, but meld into previous commit

# f, fixup <commit> = like "squash", but discard this commit's log message

# x, exec <command> = run command (the rest of the line) using shell

# b, break = stop here (continue rebase later with 'git rebase --continue')

# d, drop <commit> = remove commit

# l, label <label> = label current HEAD with a name

# t, reset <label> = reset HEAD to a label

# m, merge [-C <commit> | -c <commit>] <label> [# <oneline>]

# . create a merge commit using the original merge commit's

# . message (or the oneline, if no original merge commit was

# . specified). Use -c <commit> to reword the commit message.

#

# These lines can be re-ordered; they are executed from top to bottom.

#

# If you remove a line here THAT COMMIT WILL BE LOST.

"~/django/.git/rebase-merge/git-rebase-todo" 27L, 1213C

```

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 11, 2022, 4:53pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/12 "2022-10-11T16:53:26Z")

</div>

Your best bet would be to google an article or two on rebasing here.

**But** 😜 I recommend trying a GUI, which generally handle the nasty details for you.

I use Fork daily: [https://git-fork.com/](https://git-fork.com/)

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 11, 2022, 6:23pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/13 "2022-10-11T18:23:48Z")

</div>

When you say “update the release notes and version changed annotations for Django 4.2”, what do you mean?

---

<div class="post-metadata">

**Author:** ![nimra200](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/nimra200/32/10295_2.png) [@nimra200](https://forum.djangoproject.com/u/nimra200)\
**Post date:** [October 11, 2022, 6:24pm UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/14 "2022-10-11T18:24:20Z")

</div>

Thanks for the suggestion! I ended up using sourcetree which was free to use

---

<div class="post-metadata">

**Author:** ![carltongibson](https://sea2.discourse-cdn.com/flex026/user_avatar/forum.djangoproject.com/carltongibson/32/267_2.png) [@carltongibson](https://forum.djangoproject.com/u/carltongibson)\
**Post date:** [October 12, 2022, 8:10am UTC](https://forum.djangoproject.com/t/unsure-of-how-to-contribute-to-issue-32819/16337/15 "2022-10-12T08:10:11Z")

</div>

If you look at the PR you’ll see changes to `docs/releases/4.1.txt` — which are the Django 4.1 release notes. Those need moving to `docs/releases/4.2.txt`.

Similarly there are `versionchanged` annotations that need updating to `4.2`.