[asking for feedback] django-valkey rework

Django Internals Mentorship
1

hi again :raising_hands:t3:
so for some time i’ve been refactoring django-valkey
with the goal to make it easier to maintain, and develop
the refactoring is mostly reducing repeated codes (they still exists, but less), and some change in structure

the work is gathered in this pull request

but, i now have doubts on how good this work has been, i don’t really want to reach a point where i regret all the decisions i’ve made here and be forced to do another refactoring

so, if you have the interest and the time, i’d appreciate any feedback regarding the changes, or perhaps suggestions on how to improve, or PRs, if that’s how you wish to do this

thanks for reading this :raising_hands:t3:

2

@amirreza8002
Thanks for this python package. I am using it in the project from chapters 12 - 17 in the book Django5 by Example. Keep up the good work. Is a Docker image a possibility?

3

hi :waving_hand:
you can use a dockerized valkey, and you can have your project in docker
if that’s what you mean