Question about TODO in ChangeList ordering

Django Internals
1

Hi, While reading the Django admin code I noticed this TODO in
BaseModelAdmin.get_queryset():

# TODO: this should be handled by some parameter to the ChangeList.

Currently ordering seems to be applied in two places:

  1. BaseModelAdmin.get_queryset() applies ordering directly to the queryset
  2. ChangeList.get_queryset() also retrieves ordering via
    model_admin.get_ordering(request)

This appears to duplicate responsibility between ModelAdmin and ChangeList. Would the intended direction be to handle ordering entirely in ChangeList, for example by passing the ordering when constructing ChangeList inside ModelAdmin.get_changelist_instance(), instead of ChangeList calling model_admin.get_ordering() directly?

Thanks!

1 Like