PR template update: Ask that contributors not resolve conversations themselves

I must admit that I resolve conversations on my own PRs to help me track what I have done and what I haven’t done. Resolving very small suggestions for things like typos I think is fine? (this is where I learn everyone hates it :joy:)

I guess the issue is if people are resolving non-trivial discussions or suggestions which the reviewer/merger needs to validate was resolved properly.

GitHub also starts to hide conversations and items on it’s own when there are a lot (like in this PR: Accessibility guidelines for all contributors by thibaudcolas · Pull Request #17338 · django/django (github.com)). It also marks some things as ‘outdated’ when the comment was against code that has changed and this can also hide comments.
So unfortunately, I think if things being hidden is a bad thing, I don’t think GitHub is helping.

The more complicated PRs receive so much feedback and keeping on top of all of it is tough.
Maybe it’s worth us organising the sprint retrospective idea, so we can gather feedback on the pain points of the review process.

Note: if I see that you didn’t resolve the conversation yourself and it’s non-trivial, I could confirm with you if you think it’s addressed? We could maybe have that you emoji react :white_check_mark: when they resolved it but you’re happy it’s resolved.

1 Like