Ticket #36489 follow up: get_or_create()/update_or_create() calls on a OneToOneField

Django Internals ORM
1

Hi everyone,

I’m looking for advice on how to follow up on a PR that hasn’t received a review yet.

I submitted a fix for ticket #36489 back in September (a race condition bug where concurrent get_or_create()/update_or_create() calls on a OneToOneField could leave a stale unsaved object (pk=None) cached on the reverse relation.
Since then there hasn’t been any further activity.

PR: Fixed #36489 -- Fixed stale reverse OneToOne cache in get_or_create by sinachaichi · Pull Request #19890 · django/django · GitHub
Trac: #36489 (OneToOneField + concurrent get_or_create results in wrong object in field cache) – Django

What’s the recommended way to follow up? Is there anything I can do to help move this forward?

Thanks!

2

Thanks for your patience. What you’ve done here is the best way to follow up. We have about 90 PRs waiting for a review, and yours has been waiting almost the longest. Speaking for myself only, I pick from the list non-sequentially to minimize context switches (for example, if I recently triaged a ticket in that area). That said, I do look at who’s been waiting longest, so I would expect it wouldn’t take that much longer to get an initial review. Cheers!

1 Like
3

Thanks Jacob :slight_smile: I understand, no problem

1 Like