Django Fellow Report - Sarah - 2024

[sarahboyce]

Hello hello! I had a great first week
Thank you to everyone who has given and offered support for me in the role

Week ending 2024-04-07 (Week 14)

Triaged

• #35348 - Inconsistent behaviour with annotate using concat and GenericIPAddressField - (needsinfo)
• #35348 - Transaction API does not respect the DATABASE_ROUTERS configuration - (wontfix)
• #35269 - GeneratedFields can’t be defined on RelatedFields - (invalid)
• #35352 - Unable to continue using custom languages with Django - (invalid)

Reviewed

• Fixed #26739 – Made reverse RemoveField handle non-nullable columns. by DevilsAutumn · Pull Request #16890 · django/django (github.com)
• Fixed #7732 Support for connection pooling in oracle backend by suraj-ora-2020 · Pull Request #17834 · django/django (github.com)
• Refs #31405 – Added LoginRequiredAuthenticationMiddleware force all views to require authentication by default by Hisham-Pak · Pull Request #17792 · django/django (github.com)
• Fixed #32406 Support UPDATE RETURNING by aivarsk · Pull Request #17307 · django/django (github.com)
• Refs #35169 – Added test for ASGIRequest root_path handling. by carltongibson · Pull Request #18048 · django/django (github.com)
• Refs #21961 : Added support for database-level cascading options by Akash-Kumar-Sen · Pull Request #16851 · django/django (github.com)

Authored

• Fixed SeleniumTests.test_related_object_update_with_camel_casing() assert. by sarahboyce · Pull Request #18043 · django/django (github.com)
• Add myself as a Django Fellow. by sarahboyce · Pull Request #1513 · django/djangoproject.com (github.com)

Other/Misc

• Lots of onboarding catch-ups with Natalia that covered processes and questions, including observing the 5.0.4 release and going over Django’s security process
• Created a forum proposal on creating further teams for reviewing PRs: Should Django have review teams e.g. for the ORM - Django Internals - Django Forum (djangoproject.com)
• Confirmed which versions of MySQL Trac ticket #30224 impacted: #30224 (Mysql Datetime value is string instead of datetime object) – Django

[sarahboyce]

Week ending 2024-04-14 (Week 15)

Triaged

• #35362 - ArrayField with nested CharField with a max_length silently truncates overlong values (accepted → duplicate)
• #35363 - Makemigrations: option to “depend on most current everything” (wontfix)
• #35365 - Add RFC 3824 Auto-Submitted header to emails by default (accepted)

Reviewed

• Fixed #18119 – Added a DomainNameValidator validator. by nmenezes0 · Pull Request #18037 · django/django (github.com)
• Fixed #24686 – Allow moving a model between apps. by DevilsAutumn · Pull Request #16905 · django/django (github.com)
• Added #34277 – Add Conditional WHERE Clause to bulk_create for SQLite and PostgreSQL by HamaBarhamou · Pull Request #17515 · django/django (github.com)
• Fixed #35364 – Stopped AdminEmailHandler rendering email unnecessarily. by adamchainz · Pull Request #18059 · django/django (github.com)
• Refs #35194 – Adjusted a generated field test to work on Postgres 15.6+. by charettes · Pull Request #18065 · django/django (github.com)
• Fixed #35189 – Render admin collapsible fieldsets with <details>. by MHLut · Pull Request #17910 · django/django (github.com)

Authored

• Fixed #35350 – Fixed save() with pk set on models with GeneratedFields. by sarahboyce · Pull Request #18058 · django/django (github.com)
• Made postgresql.tests.Tests.test_connect_pool less flakey by increasing timeout value. by sarahboyce · Pull Request #18061 · django/django (github.com)

Other/Misc

• Discussed resolution for Send mail throws UnicodeEncodeError under python 3.11.9 - Django Internals - Django Forum (djangoproject.com)
• Onboarding meeting with Natalia (now setup to push changes to other people’s branches and backport)
• Backported a few commits

[sarahboyce]

Week ending 2024-04-21 (Week 16)

Triaged

• #35375 - Original line of tabular inline admin is always shown on the left, even in RTL (accepted)
• #35376 - Prefetched data not used when combining prefetch_related() and only() (duplicate)
• #35378 - Incorrect folding of long address headers with special characters when using 7bit Content-Transfer-Encoding in EmailMessage (accepted)
• #35379 - Possible error in documentation (invalid)
• #35383 - Add support for IF NOT EXISTS when creating postgres indexes concurrently (duplicate)
• #35384 - Assigning a file without a name property to a FileField results in file getting discarded silently (accepted)

Reviewed

• Fixed backends.oracle.tests.TransactionalTests.test_hidden_no_data_found_exception() on oracledb >= 2.1.2. by felixxm · Pull Request #18074 · django/django (github.com)
• Fixed #35359 – Made autodetector add fields referenced by GeneratedField.expression before it. by DevilsAutumn · Pull Request #18068 · django/django (github.com)
• Refs #21961 : Added support for database-level cascading options by Akash-Kumar-Sen · Pull Request #16851 · django/django (github.com)
• Fixed #35375 – Fixed tabular inline admin original line to be on the right in RTL. (solution 1) · django/django@c4110f6 (github.com)
• Fixed #35189 -- Render admin collapsible fieldsets with <details>. by MHLut · Pull Request #17910 · django/django · GitHub
• Fixed #35373 – Fixed a crash when indexing a generated field on SQLite. by charettes · Pull Request #18079 · django/django (github.com)
• Added JS wait in test_inline_add_another_widgets. by MHLut · Pull Request #18082 · django/django (github.com)
• Fixes #34994 and #35386 – Applied checkbox-row unconditionally in Admin. · django/django@3d373bc (github.com)
• Refs #34976 – Print directory structure after startapp and startproject by TobeTek · Pull Request #17838 · django/django (github.com)
• Refs #34976 – Provide feedback when startapp and startproject are called by salvo-polizzi · Pull Request #17722 · django/django (github.com)
• ticket-[35321] by Jkhall81 · Pull Request #18013 · django/django (github.com)
• Fixed #24686 – Allow moving a model between apps. by DevilsAutumn · Pull Request #16905 · django/django (github.com)

Authored

• Added a forced-colors mode screenshot_cases. by sarahboyce · Pull Request #18080 · django/django (github.com)
• Fixed #35194 – Fixed case-insensitive operations in GeneratedFields on Postgres 15.6+. by sarahboyce · Pull Request #18085 · django/django (github.com) (closed - wrong approach)
• Reverted release notes for bdd76c4c3817d8e3ed5b0450d5e18e4eae096f16. by sarahboyce · Pull Request #18090 · django/django (github.com)

Other/Misc

• I made a mistake backporting Fixes #34994 and #35386 – Applied checkbox-row unconditionally in Admin. by adamchainz · Pull Request #18086 · django/django (github.com) and subsequently needed to revert the backports and the release notes. I hate making mistakes but it has helped me understand the backporting policy better and given me experience in a revert. If I set-up a blog, I will add some reflections there.

[sarahboyce]

Week ending 2024-04-28 (Week 17)

Short week as I was returning from my hen/bachelorette night and helped a friend move house.

Triaged

• #35393 - InlineAdmin’s are not possible with an editable UUIDField as primary key. (accepted)
• #35397 - override_settings for STORAGES loses OPTIONS (invalid)
• #35398 - If the JSONField contains numbers key, the hash_key query becomes invalid (duplicate)
• #35400 - SECRET_KEY_FALLBACKS documentation can be misleading when running multiple instances of an application (invalid)
• #35401 - Document the conditional_page decorator (accepted)
• #35402 - DatabaseFeatures.django_test_skips crashes when it references a class in another test module (accepted)
• #35403 - URL path with optional parameter (invalid)
• #35404 - Admin fieldset multiple flexbox regressions (accepted)
• #35406 - Using Django models in function type annotations, without dependency to settings.configure() (invalid)

Reviewed

• Fixed #24686 – Allow moving a model between apps. by DevilsAutumn · Pull Request #16905
• Fixed #12090 – Show admin actions on the edit pages too by mgaligniana · Pull Request #16012
• Fixed #35382 – removed unused CSS in .inline-related fieldset.module h3
• Fixed #35395 – slice filter crashes on an empty dict with Python 3.12 by timrichardson · Pull Request #18096
• Fixed #35326 -- handled temporary uploaded files for OverwritingStorage. by bcail · Pull Request #18020 · django/django · GitHub
• Fixed#35137 - Interactive Collapsible error container by abhijeet-singh800 · Pull Request #17784
• Fixed #35365 – Add RFC 3824 Auto-Submitted header to emails by default by cgracin · Pull Request #18099
• Refs #17235 – Made MultiPartParser leave request.FILES immutable. by bcail · Pull Request #17991
• Fixed #35328 - Improved debug messaging behind proxies. by ryanhiebert · Pull Request #18014
• Fixed #26739 – Made reverse RemoveField handle non-nullable columns. by DevilsAutumn · Pull Request #16890
• Fix #8307 – Saving a model with an ImageField with width_field or height_field no longer results in an extra read operation [Alternate Proposal] by john-parton · Pull Request #18070