Django Fellow Report - Sarah - 2024

sarahboyce · April 8, 2024, 6:45am

Hello hello! I had a great first week
Thank you to everyone who has given and offered support for me in the role

Week ending 2024-04-07 (Week 14)

Triaged

#35348 - Inconsistent behaviour with annotate using concat and GenericIPAddressField - (needsinfo)
#35348 - Transaction API does not respect the DATABASE_ROUTERS configuration - (wontfix)
#35269 - GeneratedFields can’t be defined on RelatedFields - (invalid)
#35352 - Unable to continue using custom languages with Django - (invalid)

Reviewed

Fixed #26739 – Made reverse RemoveField handle non-nullable columns. by DevilsAutumn · Pull Request #16890 · django/django (github.com)
Fixed #7732 Support for connection pooling in oracle backend by suraj-ora-2020 · Pull Request #17834 · django/django (github.com)
Refs #31405 – Added LoginRequiredAuthenticationMiddleware force all views to require authentication by default by Hisham-Pak · Pull Request #17792 · django/django (github.com)
Fixed #32406 Support UPDATE RETURNING by aivarsk · Pull Request #17307 · django/django (github.com)
Refs #35169 – Added test for ASGIRequest root_path handling. by carltongibson · Pull Request #18048 · django/django (github.com)
Refs #21961 : Added support for database-level cascading options by Akash-Kumar-Sen · Pull Request #16851 · django/django (github.com)

Authored

Other/Misc

Lots of onboarding catch-ups with Natalia that covered processes and questions, including observing the 5.0.4 release and going over Django’s security process
Created a forum proposal on creating further teams for reviewing PRs: Should Django have review teams e.g. for the ORM - Django Internals - Django Forum (djangoproject.com)
Confirmed which versions of MySQL Trac ticket #30224 impacted: #30224 (Mysql Datetime value is string instead of datetime object) – Django

sarahboyce · April 15, 2024, 6:57am

Week ending 2024-04-14 (Week 15)

Triaged

#35362 - ArrayField with nested CharField with a max_length silently truncates overlong values (accepted → duplicate)
#35363 - Makemigrations: option to “depend on most current everything” (wontfix)
#35365 - Add RFC 3824 Auto-Submitted header to emails by default (accepted)

Reviewed

Fixed #18119 – Added a DomainNameValidator validator. by nmenezes0 · Pull Request #18037 · django/django (github.com)
Fixed #24686 – Allow moving a model between apps. by DevilsAutumn · Pull Request #16905 · django/django (github.com)
Added #34277 – Add Conditional WHERE Clause to bulk_create for SQLite and PostgreSQL by HamaBarhamou · Pull Request #17515 · django/django (github.com)
Fixed #35364 – Stopped AdminEmailHandler rendering email unnecessarily. by adamchainz · Pull Request #18059 · django/django (github.com)
Refs #35194 – Adjusted a generated field test to work on Postgres 15.6+. by charettes · Pull Request #18065 · django/django (github.com)
Fixed #35189 – Render admin collapsible fieldsets with <details>. by MHLut · Pull Request #17910 · django/django (github.com)

Authored

Other/Misc

Discussed resolution for Send mail throws UnicodeEncodeError under python 3.11.9 - Django Internals - Django Forum (djangoproject.com)
Onboarding meeting with Natalia (now setup to push changes to other people’s branches and backport)
Backported a few commits

sarahboyce · April 23, 2024, 6:17am

Week ending 2024-04-21 (Week 16)

Triaged

#35375 - Original line of tabular inline admin is always shown on the left, even in RTL (accepted)
#35376 - Prefetched data not used when combining prefetch_related() and only() (duplicate)
#35378 - Incorrect folding of long address headers with special characters when using 7bit Content-Transfer-Encoding in EmailMessage (accepted)
#35379 - Possible error in documentation (invalid)
#35383 - Add support for IF NOT EXISTS when creating postgres indexes concurrently (duplicate)
#35384 - Assigning a file without a name property to a FileField results in file getting discarded silently (accepted)

Reviewed

Authored

Other/Misc

I made a mistake backporting Fixes #34994 and #35386 – Applied checkbox-row unconditionally in Admin. by adamchainz · Pull Request #18086 · django/django (github.com) and subsequently needed to revert the backports and the release notes. I hate making mistakes but it has helped me understand the backporting policy better and given me experience in a revert. If I set-up a blog, I will add some reflections there.

sarahboyce · April 29, 2024, 6:19am

Week ending 2024-04-28 (Week 17)

Short week as I was returning from my hen/bachelorette night and helped a friend move house.

Triaged

#35393 - InlineAdmin’s are not possible with an editable UUIDField as primary key. (accepted)
#35397 - override_settings for STORAGES loses OPTIONS (invalid)
#35398 - If the JSONField contains numbers key, the hash_key query becomes invalid (duplicate)
#35400 - SECRET_KEY_FALLBACKS documentation can be misleading when running multiple instances of an application (invalid)
#35401 - Document the conditional_page decorator (accepted)
#35402 - DatabaseFeatures.django_test_skips crashes when it references a class in another test module (accepted)
#35403 - URL path with optional parameter (invalid)
#35404 - Admin fieldset multiple flexbox regressions (accepted)
#35406 - Using Django models in function type annotations, without dependency to settings.configure() (invalid)

Reviewed

sarahboyce · May 6, 2024, 6:47am

Week ending 2024-05-05 (Week 18)

Wednesday May 1st was a bank holiday here. There is a cute tradition in the region of Cologne Germany that boys will find a young birch tree, decorate it with ribbons, and leave it outside the house of their sweetheart for the 1st of May. On leap years, like this year, the girls do this for the boys
The May Tree – DW – 06/14/2007

The week was mostly focused on release blockers for Django 5.0.5 and prep to be able to release on May 6th.

This is also the end of my first month as Fellow

Triaged

#35411 - Checkboxes in admin panel extend off page depending on page size. (duplicate)
#35413 - FieldError: Unsupported lookup error message can be confusing. (accepted)
#35414 - Issue with AsyncClient ignoring default headers compared to synchronous Client (needsinfo → invalid)
#35415 - Adding content_type to StreamingHttpResponse on Linux causes memory error after streaming around 1GB-2GB of data. (needsinfo → invalid)
#35417 - RequestContext.new creates a context that cannot be flattened (accepted)
#35420 - Add support for RSS stylesheets (duplicate)
#35418 - ValueError: site must subclass AdminSite (accepted)
#35427 - Details of extension argument for makemessages management command not correct (accepted)
#35426 - GenericPrefetch should have queryset parameter as required (accepted)
#35424 - Migration autodetector fails when order_with_respect_to is removed, but an _order field remains (accepted → needsinfo)
#35430 - Documentation about timezone is misleading (accepted)
#35433 - NumberInput min_value attr overridden by IntegerField.widget_attrs (needsinfo → wontfix)

Reviewed

Other/Misc

Received advice/support from lots of current and former Fellows thank you to each of you

Discussed and tried to better understand when we decide to deprecate with Carlton
Discussed how to resolve the release blockers with Mariusz
Had setup support for releasing Django with Natalia

sarahboyce · May 13, 2024, 6:19am

Week ending 2024-05-12 (Week 19)

Thursday was also a bank holiday here (May has a lot).
The main thing of the week was issuing the release for the first time and it later getting yanked. Was a tough week but really appreciated those who supported and those who checked in.

Triaged

#34606 - Migrations generates code that it can’t execute (invalid)
#35434 - prefetch_related_objects fails to cache UUID FKs when the string representation of a UUID is used (needsinfo)
#35438 - Failed to insert an model instance into db that utilizes a UUID as its primary key and incorporates a GeneratedField. (needsinfo - potential release blocker)
#35424 - Migration autodetector fails when order_with_respect_to is removed, but an _order field remains (worksforme → accepted)

Reviewed

Authored

Added release notes for 5.0.6 and 4.2.13. by sarahboyce · Pull Request #18140

Other/Misc

Released Django 5.0.5 and 4.2.12 (with lots of help from Natalia), this release had a packaging issue due to being built on Windows and was then yanked

sarahboyce · May 21, 2024, 7:21am

Week ending 2024-05-19 (Week 20)

Triaged

#35443 - Fix negative numbers for ordinals (accepted)
#35445 - Adding model field validators to FloatField and IntegerField is not possible. (invalid)
#35449 - SplitArrayField doesn’t validate properly with remove_trailing_nulls=True (accepted)
#35450 - Missing documentation: deploying Django in production behind a proxy. (accepted)
#35451 - Documentation: Gunicorn deployment should probably mention the usage of a proxy (accepted)
#35453 - ManyToMany field is a concrete field on the defining side. (invalid)
#10554 - Response.set_cookie should allow setting two cookies of the same name. (accepted)
#35457 - Documentation: Code inside of text box (wontfix)
#35456 - Fieldset title inside a collapsed StackedInline are h3 but on errors are shown as h2 (duplicate)
#35461 - Tutorial instructions for adding django-debug-toolbar are misleading. (accepted)
#35464 - Case.extra is undocumented, untested, and can hide potential issues (accepted)
#35464 - Fieldsets defined for TabularInlines are ignored (accepted)

Reviewed

Authored

Moved FileSystemStorage note in docs to the correct place. by sarahboyce · Pull Request #18171

sarahboyce · May 27, 2024, 6:42am

Week ending 2024-05-26 (Week 21)

Monday was a BH again so short week

Triaged

#35467 - Prefer urlsplit() over urlparse() (accepted)
#35465 - Feature: allow pre-caching and disable-cache (wontfix)
#35463 - Squash migrations inheriting dependencies from unsquashed migrations. (duplicate)
#35458 - Docs: clarify need for ALLOWED_HOSTS (needsinfo)
#35470 - Separate i18n and l10n globalization settings into two sublists. (accepted)
#35471 - Make the admin search filter optional in nav sidebar? (wontfix)
#35469 - Squashing migrations from unique=True to unique=False to UniqueConstraint produces irreversible migration on Postgres (accepted)
#35472 - Image files aren’t cleaned up after running tests (accepted)
#35475 - In admin sidebar, hide empty app headers (wontfix)
#35474 - django use oracledb and enable thick mode，but sometimes Aborted (invalid)
#35476 - The precedence of multiple translations for the same literal does not work on Python3.11 & Python3.12 (accepted)
#35477 - Required field error added to new_password1 on forms that inherit SetPasswordForm with additional new_password1 level validation. (accepted)
#35478 - GenericRelation always deletes the related objects when a model object is deleted (duplicate)

Reviewed

Authored

Fixed #35472 – Used temporary directory in test_imagefield.NoReadTests. by sarahboyce · Pull Request #18190

sarahboyce · May 31, 2024, 1:07pm

Week ending 2024-06-02 (Week 22)

Bank holiday on Thursday and taking some time off for a little while

Triaged

#35479 - Drop support for PostgreSQL 13 and PostGIS 3.0. (accepted)
#35482 - Email and URL form input widgets should always have dir=“ltr” (accepted)
#35485 - Template documentation for startproject / startapp is very sparse. (accepted)
#35484 - Enhances the flexibility of the Django admin interface by supporting custom user models more effectively. (duplicate)
#35483 - ModelMultipleChoiceField with CharField key throws ValueError if data contains NUL (0x00) characters (accepted)
https://code.djangoproject.com/ticket/35486 (invalid)
#35488 - BaseModelFormSet.validate_unique() raises unhashable type error for unique fields with unhashable types (accepted)

Reviewed

Other/Misc

Engaged in discussions on the security mailing list

sarahboyce · June 12, 2024, 6:51am

Week ending 2024-06-09 (Week 23)

Holiday for my wedding

sarahboyce · June 17, 2024, 6:20am

Week ending 2024-06-16 (Week 24)

Was still on holiday at the start of the week but I’m back! Had the best time

Triaged

#35502 - In the tutorial we have two mysite directories, and we often see users confused by that. (accepted)
#35511 - Documentation uses the py binary in Windows, which may not always be available (accepted)
#35517 - Improve test coverage of shell command (accepted)
#35504 - Bug running test i18n.test_extraction.UnchangedPoExtractionTests on WSL cause of CRLF/LF issue (needsinfo)
#35504 - Bug running test i18n.test_extraction.UnchangedPoExtractionTests on WSL cause of CRLF/LF issue (invalid)
#35493 - Allow ./ and ../ in paths when recursively including templates (accepted)
#35522 - ‘NoneType’ object has no attribute ‘lstrip’ when loading single template with relative include without origin (needsinfo)
#35518 - Avoid regex search for simple route patterns (needsinfo)
#35513 - Add a seprarate_dirname_filename method in core file storage (duplicate)
#35524 - Add possibility to renew {% cache %} templatetag (wontfix)
#35516 - Setting Client Name for Redis Connections (wontfix)
#35521 - Make it easy to add CSS classes to a BoundField (wontfix)
#35508 - Add an --ignore-deps flag to squashmigrations (accepted)
#35498 - Race-condition using Django pylibmc implementation (PyLibMCCache) (duplicate)

Reviewed

Other/Misc

Backported some bug fixes to 5.1 as during the alpha phase

sarahboyce · June 24, 2024, 7:00am

Week ending 2024-06-23 (Week 25)

Triaged

#35502 - In the tutorial we have two mysite directories, and we often see users confused by that. (accepted → wontfix)
#35528 - Add EmailMultiAlternatives.body_contains() to aid email test assertions (accepted)
#35523 - query_string cannot use variables as keys (wontfix)
#35533 - urlize() makes a bit of a mess of links embedded in Markdown (accepted)
#35534 - Request attribute upload handlers is immutable when method is POST (invalid)
#35535 - Simple block tag (wontfix)
#35532 - Allow customizing errors processing in BaseModelFormSet.validate_unique() (wontfix)
#35536 - Incorrect represent empty list from JSONField in ChangeList (wontfix)
#35192 - Support injecting custom context into widget templates (needsinfo)
#35543 - Contribution: new management commands for contrib.auth (grantpermissions, revokepermissions) (wontfix)
#35539 - SearchVector GinIndex raises IMMUTABLE error
(accepted → invalid)
#35546 - Modernize contributing pages to aling with current requirement of having an accepted ticket for non trivial changes (accepted)
#35547 - reset_queries cannot be imported from django.db (accepted)
#35544 - Readonly Widget Template (duplicate)

Reviewed

Authored

Other/Misc

Went through the Django tutorial to test an instruction update but also update images along the way. Lead to the following issue reports:
- #35541 - Admin changelist total row css issue
- #35540 - Admin login form padding issue

sarahboyce · July 1, 2024, 6:35am

Week ending 2024-06-30 (Week 26)

Triaged

#35553 - HashedFilesMixin for ES modules does not work with import*as ... syntax (invalid → accepted)
#35552 - [Django Admin] Harmonizing obj=None parameter across multiple function (wontfix)
#35551 - Fix changing PK via admin (accepted)
#35564 - Improve readability of subclass identification in admin and auth checks (accepted → duplicate)
#35565 - system connectivity diagnostics in admin panel (wontfix)
#35530 - django.contrib.auth.login inconsistently guards request.user (needsinfo)
#35365 - Add RFC 3834 Auto-Submitted header to emails by default (accepted → wontfix)
#35378 - Incorrect folding of long address headers with special characters when using 7bit Content-Transfer-Encoding in EmailMessage (accepted → invalid)

Reviewed

Authored

Other/Misc

Security related work.

sarahboyce · July 8, 2024, 6:48am

Week ending 2024-07-07 (Week 27)

Short week this week as I had a long weekend hiking with some friends in Bavaria

Triaged

#35566 (Support get_FOO_display() on GeneratedField) – Django (accepted)
#35451 (Documentation: Gunicorn deployment should probably mention the usage of a proxy) – Django (accepted → wontfix)
#35450 (Missing documentation: deploying Django in production behind a proxy.) – Django (accepted → wontfix)
#35572 (Improve performance replacing os.listdir() with os.scandir()) – Django (djangoproject.com) (accepted)
#35575 (Add support for constraint validation on GeneratedFields) – Django (accepted)

Reviewed

Authored

Fixed #35566 – Added get_FOO_display() support for GeneratedFields· Pull Request #18330

Other/Misc

Security related work

CodenameTim · July 9, 2024, 1:56pm

And no picturesque mountain photos?!

sarahboyce · July 9, 2024, 3:21pm

If you insist

sarahboyce · July 15, 2024, 8:15am

Week ending 2024-07-14 (Week 28)

Was a bit poorly mid week but finished the week feeling much better and had a birthday weekend on the Dutch coast

Triaged

#35532 (Allow customizing errors processing in BaseModelFormSet.validate_unique()) – Django (wontfix)
#35584 (Discard user full names from admin log entries) – Django (wontfix)
#35590 (Some translation problems) – Django (invalid)
#35591 (Add warning to runserver that it should not be used for production) – Django (accepted)
#35595 (Generated migration for removing related models can't migrate backwards) – Django (accepted)
#35593 (collectstatic does not preserve source file timestamps) – Django (needsinfo)

Reviewed

Authored

Added tests for urlize handling of trailing semicolons. by sarahboyce · Pull Request #18358 · django/django (github.com)

Other/Misc

Delivered a talk on contributing to Django
Engaged in security topics

sarahboyce · July 22, 2024, 6:03am

Week ending 2024-07-21 (Week 29)

Triaged

#35596 (Database access optimization warning that get() can retrieve hundreds or thousands of records is outdated) – Django (accepted)
#35604 (Unexpected behaviour of FileSystemStorage.exists() due to latest changes) – Django (djangoproject.com) (accepted)
#35605 (Django 5.0 version. Some parts of the document still display English after selecting Chinese language, without Chinese translation.) – Django (invalid)
#35602 (Allow simple_tag to be defined and used in a for loop) – Django (wontfix)
#35606 (Admin changelist broken for model instances with __html__ method) – Django (accepted)
#35608 (Regression: many-to-many fields are not being correctly persisted to db from the admin) – Django (needsinfo)
#35611 (Admin action without the need to select objects) – Django (wontfix)
https://code.djangoproject.com/ticket/35609 (needsinfo)
#35607 (Improve Storage base backend API flexibility to allow filename validation to be overridden safely) – Django (accepted)
#35589 (AlterField should raise an error when changing primary key) – Django (djangoproject.com) (worksforme)
#35616 ("url" template tag works with a context variable only if left unquoted) – Django (invalid)
#35619 (django.core.files.uploadfile.InMemoryUploadedFile ignores chunk_size) – Django (djangoproject.com) (invalid)

Reviewed

Authored

Other/Misc

Engaged in security topics
Created: #35612 (Emphasise user responsibility within "Reporting security issues" to detail invalid reports) – Django

sarahboyce · July 29, 2024, 6:15am

Week ending 2024-07-28 (Week 30)

Triaged

#35623 (Document that fields cannot be named 'check') – Django (accepted)
#35615 (Add ability to render request.user in templates when async is used) – Django (accepted)
#35627 (LocaleMiddleware does not handle ValueError 'lang_code' exceeds the maximum accepted length) – Django (accepted)
#35629 (Implement async cursors) – Django (accepted)
#35630 (django.utils.formats.sanitize_strftime_format() no longer works correctly with Python 3.13.0b4) – Django (djangoproject.com) (duplicate)

Reviewed

Other/Misc

Engaged in security topics.
Had laptop setup with a dual boot to have Ubuntu installed (for releasing) and then lots of installing and set up

sarahboyce · August 5, 2024, 5:49am

Week ending 2024-08-04 (Week 31)

Been prepping for the upcoming 5.0.8 and 4.2.15 release - wish me luck (I might need it)

Triaged

#35636 (differentiate placeholder and content provider blocks) – Django (wontfix)
#35632 (The Date and DateTime field widget act like a text field (In class based view)) – Django (needsinfo)
#35645 (Inline H3 header style is visually stronger than the page's H1 (admin, light theme).) – Django (accepted)
#35647 (Templating Engine Auto-Closing Forms) – Django (invalid)
#35646 (SafeExceptionReporterFilter should filter settings and headers such as HTTP_AUTHORIZATION) – Django (accepted)
#35649 (Adding documentation to html.py (docstrings, inline comments etc)) – Django (invalid)
#27452 (Add Postgres serial field to contrib.postgres) – Django (wontfix)
#35653 (Support EMAIL_SSL_CERTFILE for private certificate authority) - Django (duplicate → accepted)
#35654 (SystemCheckError on GenericRelation with lazy reference) – Django (needsinfo)
#35651 (RedisCacheClient does not reuse connections from the connection pool) - Django (needsinfo → accepted)

Reviewed

Authored

Fixed #35655 -- Reverted "Fixed #35295 -- Used INSERT with multiple rows on Oracle 23c." by sarahboyce · Pull Request #18440 · django/django · GitHub

Other/Misc

Engaged in security topics

Topic		Replies	Views
Django Fellow Report - Natalia Django Internals	49	2609	January 9, 2024
[GSOC 2023] Add Configurable Content Type Parsing and Modernise Request Object Mentorship	15	1033	August 1, 2023
Django Fellow Report - Natalia - 2024 Django Internals	46	1857	November 18, 2024
GSOC 2022 help and guidance Mentorship	1	567	April 19, 2022
GSOC 2023 Discussion and Feedback: Database-level Cascades Mentorship	2	379	April 1, 2023

Django Fellow Report - Sarah - 2024

Week ending 2024-04-07 (Week 14)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-04-14 (Week 15)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-04-21 (Week 16)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-04-28 (Week 17)

Triaged

Reviewed

Week ending 2024-05-05 (Week 18)

Triaged

Reviewed

Other/Misc

Week ending 2024-05-12 (Week 19)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-05-19 (Week 20)

Triaged

Reviewed

Authored

Week ending 2024-05-26 (Week 21)

Triaged

Reviewed

Authored

Week ending 2024-06-02 (Week 22)

Triaged

Reviewed

Other/Misc

Week ending 2024-06-09 (Week 23)

Week ending 2024-06-16 (Week 24)

Triaged

Reviewed

Other/Misc

Week ending 2024-06-23 (Week 25)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-06-30 (Week 26)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-07-07 (Week 27)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-07-14 (Week 28)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-07-21 (Week 29)

Triaged

Reviewed

Authored

Other/Misc

Week ending 2024-07-28 (Week 30)

Triaged

Reviewed

Other/Misc

Week ending 2024-08-04 (Week 31)

Triaged

Reviewed

Authored

Other/Misc

Related topics