Django Fellow Report - Natalia - 2024

[nessita]

Week ending 2024-01-07 (Week 01)

Back from holidays! I spent some time doing catch up with emails and various Django conversation platforms.

Triaged

• #35083 (Make django.utils.decorators.method_decorator work with async functions.) – Django - Make django.utils.decorators.method_decorator work with async functions. (accepted)
• #35085 (Import of PyATS breaks runserver reloader) – Django - Import of PyATS breaks built-in server (needsinfo)

Reviewed

• Used enterClassContext() where appropriate. by felixxm · Pull Request #17673 · django/django · GitHub - Used enterClassContext() where appropriate.
• Fixed #34806 -- Made the cached_db backend resilient to cache backend errors. by sulabhkatila · Pull Request #17220 · django/django · GitHub - Fixed #34806 – Made the cached_db backend resilient to cache backend errors.
• Fixed #1459 -- Fixed get_all_doc_versions template tag. by felixxm · Pull Request #1460 · django/djangoproject.com · GitHub - Fixed #1459 – Fixed get_all_doc_versions template tag.
• Ticket 35059 - call response.close, or failing that request_finished.send, if processing is cancelled by jthorniley · Pull Request #17675 · django/django · GitHub - Ticket 35059 - call response.close, or failing that request_finished.send, if processing is cancelled
• Fixed #34429 -- Allowed setting unusable password via admin UI. by fsbraun · Pull Request #16942 · django/django · GitHub - Fixed #34429 – Allowed setting unusable password via admin UI.
• Reorganized the Contributing to Django docs. by marksweb · Pull Request #17564 · django/django · GitHub - Reorganized Contributing to Django docs.
• Fixed #34977: Make change password form reachable through button by fsbraun · Pull Request #17489 · django/django · GitHub - Fixed #34977: Make change password form reachable through button

Other/Misc

• Deep dive on translation machinery and related issues.

Study of 23321 (Remove .mo files from the Django Git repository) and Fixed #23321 -- Generated .mo files at setup time by claudep · Pull Request #3392 · django/django · GitHub

[nessita]

Week ending 2024-01-14 (Week 02)

Triaged

• #35098 (ValidationError is being converted into a 500 Internal Server Error response) – Django - ValidationError is being converted into a 500 Internal Server Error response (invalid)

Reviewed

• https://github.com/django/django/pull/16942 - Fixed #34429 – Allowed setting unusable password via admin UI.
  • Multiple rounds of reviews.
  • Dedicated a fair amount of time to fix the commit history.
• https://github.com/django/django/pull/17520 - Fixed #32819 – Established relationship between form fields and their errors.
• #34044 -- Add the admin app filter on index pages in addition to the nav sidebar by Hisham-Pak · Pull Request #17709 · django/django · GitHub - #34044 – Add the admin app filter on index pages in addition to the nav sidebar
• Fixed #35097 -- Tested parse_datetime() with bare date. by timgraham · Pull Request #17715 · django/django · GitHub - Fixed #35097 – Tested parse_datetime() with bare date.
• Fixed #34769 -- Fixed key transforms on Oracle 21c+. by felixxm · Pull Request #17717 · django/django · GitHub - Fixed #34769 – Fixed key transforms on Oracle 21c+.
• Reorganized the Contributing to Django docs. by marksweb · Pull Request #17564 · django/django · GitHub - Reorganized the Contributing to Django docs.

Authored

• Added tests ensuring that validate_password is used in AdminPasswordChangeForm. by nessita · Pull Request #17729 · django/django · GitHub - Added tests ensuring that validate_password is used in AdminPasswordChangeForm.

Other/Misc

• Deep dive on #35033 (EmailMessage repeats header if provided via the headers kwargs) – Django
  • Repeated Headers in email message - #2 by nessita
• Fixed some buggy translations for Spanish (Spanish translation pluralization issue with "año")

[nessita]

Week ending 2024-01-21 (Week 03)

Triaged

• #35115 (Empty footer element in main section of admin layout) – Django - Empty footer element in main section of admin layout (accepted)
• #35110 (in_bulk does not work with annotated fields, nor on foreign key) – Django - in_bulk does not work with annotated fields, nor on foreign key (wontfix)
• #35118 (Mention test-suggestions when specific email-backend is used) – Django - Mention test-suggestions when specific email-backend is used (invalid)
• #35124 (Could bulk_update() aggregate the pk's in WHEN clauses?) – Django - Could bulk_update() aggregate the pk’s in WHEN clauses? (invalid)
• #35119 (Unify max_length for EmailValidator and model's and form's EmailField) – Django - Unify max_length for EmailValidator and model’s and form’s EmailField (accepted)
• #35127 (Model.full_clean() errors with GeneratedField) – Django - Model.full_clean() errors with GeneratedField (accepted)
• #35125 (Parent model fields are ignored when preparing the update_fields) – Django - Parent model fields are ignored when preparing the update_fields (needsinfo)

Reviewed

• Fixed #7732 -- Added support for session pool by suraj-ora-2020 · Pull Request #17743 · django/django · GitHub - Fixed #7732 – Added support for session pool
• Refs #34038 -- Improve link readability and identifiability by yushanfans2233 · Pull Request #17419 · django/django · GitHub - Refs #34038 – Improve link readability and identifiability
• Fixed tutorial 'background.gif' reference. by adamchainz · Pull Request #17680 · django/django · GitHub - Fixed tutorial file listings.
• Preferred use of SimpleTestCase.settings() and SimpleTestCase.modify_settings(). by ngnpope · Pull Request #17690 · django/django · GitHub - Preferred use of SimpleTestCase.settings() and SimpleTestCase.modify_settings().
• Fixed #35122 -- Migrate prune command by smoeinbbp · Pull Request #17749 · django/django · GitHub - Fixed #35122 – Migrate prune command
• https://github.com/django/django/pull/17675 - Ticket 35059 - call response.close, or failing that request_finished.send, if processing is cancelled
• Fixed #34971 -- Doc'd additional loggers. by AryanGHM · Pull Request #17646 · django/django · GitHub - Fixed #34971 – Doc’d additional loggers.

Other/Misc

• Following up a former fix to a filebased cache flaky test, I spent some time debugging and analyzing the same failing test for the memcached backend.
  • Configured a local memcached and tried a few approaches.
  • Created Flaky cache tests
  • I was then pointed at #32831 (Some cache tests are flaky (e.g. cache.tests.BaseMemcachedTests.test_touch)) – Django
• Read various threads, ticket and PR about extending the cycle template tag.
  • Replied to Discord and Cycle template tag should accept a single argument

[KenWhitesell]

Did you drop the last digit of the first two tickets you’re reporting on here? The both refer to ticket 3511.

[nessita]

Yes, I’m very sorry! They are 35115 and 35110 respectively. I have edited the post. Thank you!

[nessita]

Week ending 2024-01-28 (Week 04)

Triaged

• #35137 (Collapsible error container elements do not indicate that they are interactive) – Django - Collapsible error container elements do not indicate that they are interactive (accepted)
• #35140 (Increase font size in Django debug views (404, 500, etc)) – Django - Increase font size in Django debug views (404, 500, etc) (accepted)

Reviewed

• Fixed #34971 -- Doc'd additional loggers. by AryanGHM · Pull Request #17646 · django/django · GitHub - Fixed #34971 – Doc’d additional loggers.
• Fixed #35119 -- Updated EmailField & EmailValidator max_length to 254. by skushagra · Pull Request #17763 · django/django · GitHub - Fixed #35119 – Updated EmailField & EmailValidator max_length to 254.
• https://github.com/django/django/pull/17675 - Ticket 35059 - call response.close, or failing that request_finished.send, if processing is cancelled
• Added test for the sendtestemail command when no recipients are given. by bmispelon · Pull Request #17773 · django/django · GitHub - Added test for the sendtestemail command when no recipients are given.

Other/Misc

• Triage, follow up and patch building for security reports.
• Replied to many fellowship related inquiries after the DSF published the call for applicants for the Django Fellow position.

[nessita]

Week ending 2024-02-04 (Week 05)

Triaged

• #35151 (makemigrations hangs forever on complex apps/models) – Django - makemigrations hangs forever on complex apps/models (needsinfo)
• #35147 (Document that non-wrapped arithmetic with integer fields might require explicit output_field) – Django - Extend release docs to mention that non-wrapped arithmetic against integer fields might require explicit output_field (accepted)
• #35161 (makemessages - make comments with line numbers look the same in all operating systems) – Django - makemessages - make comments with line numbers look the same in all operating systems (wontfix)

Reviewed

• Fixed #10743 -- Allowed lookup separators in list_display by knyghty · Pull Request #17357 · django/django · GitHub - Fixed #10743 – Allowed lookup separators in list_display
• https://github.com/django/django/pull/17675 - Ticket 35059 - call response.close, or failing that request_finished.send, if processing is cancelled
• Fixed #35159 -- Fixed dumpdata crash when base querysets use prefetch_related(). by felixxm · Pull Request #17801 · django/django · GitHub - Fixed #35159 – Fixed dumpdata crash when base querysets use prefetch_related().
• Fix #34746: Add a size limit for variable size when pretty printing exception report by keerthivasansa · Pull Request #17809 · django/django · GitHub - Fix #34746: Add a size limit for variable size when pretty printing exception report
• Replaced "Django test runner" with DiscoverRunner in release notes. by timgraham · Pull Request #17799 · django/django · GitHub - Replaced “Django test runner” with DiscoverRunner in release notes.

Authored

• [4.2.x] Pinned black == 23.12.1 for blacken-docs checks. by nessita · Pull Request #17793 · django/django · GitHub - [4.2.x] Pinned black == 23.12.1 for blacken-docs checks.
• [4.2.x] Pinned psf/black@23.12.1. by nessita · Pull Request #17781 · django/django · GitHub - 4.2.x] Pinned black == 23.12.1 in GitHub actions, pre-commit and test requirements.

Other/Misc

• Attended the Django Roadmap session organized and coordinated by Thibaud Colas. This was amazing, thank you!
• More triage and follow up for security reports. Sent security release announcements.
• Started work on extending the automation for fetching (only the necessary) translations from Transifex.

[nessita]

Week ending 2024-02-11 (Week 06)

This week I was out (very) sick for a few days. I’m now feeling better!

Triaged

• #35179 (Admindocs does not recognize methods containing positional-only arguments or keyword-only arguments as such) – Django - Admindocs does not recognize methods containing positional-only arguments or keyword-only arguments as such (accepted)
• #35178 (Override FORM_RENDERER for admin site) – Django - Override FORM_RENDERER for admin site (invalid)

Reviewed

• Fixed #10743 -- Allowed lookups for related fields in ModelAdmin.list_display. by knyghty · Pull Request #17357 · django/django · GitHub - Fixed #10743 – Allowed lookups for related fields in ModelAdmin.list_display.
  • Congratulations to @knyghty and @nmenezes on successfully addressing a 15-year-old ticket, now merged into Django 5.1! This is one of the oldest tickets I’ve had the opportunity to review thus far.
  • This one turned out to be more challenging than expected. Initially, there was some (anticipated) documentation polishing, but I got a bit sidetracked by the checks tests disparity (there are tests for ModelAdmin checks in two files).
  • Additionally, I faced some Selenium test failures after a refactor I pushed, due to different admin column ordering depending on the database backend. The Selenium tests on Postgresql were failing, and upon attempting to reproduce locally, I realized that my local PostgreSQL was broken due to a PG 15 → PG 16 upgrade that never completed. It was quite an interesting experience! [Mental note: do not, I repeat, do not choose Manjaro as your rebound distro. ]
• https://github.com/django/django/pull/17338 - Accessibility guidelines for all contributors
• Fixed #35173 -- Reallowed filtering with __isnull on foreign keys not listed in list_filters. by Hisham-Pak · Pull Request #17844 · django/django · GitHub - Fixed #35173 – Reallowed filtering with __isnull on foreign keys not listed in list_filters.

Authored

• Refs #10743 -- Removed leftover comment in tests/admin_changelist/tests.py. by nessita · Pull Request #17830 · django/django · GitHub - Refs #10743 – Removed leftover comment in tests/admin_changelist/tests.py.

Other/Misc

• Follow up in the forum about GitHub templates for Pull Requests.
• Django security releases issued!
  • https://www.djangoproject.com/weblog/2024/feb/06/security-releases/
• Started conversations with Mariatta (Python Core Developer) about various automation initiatives:
  • Had a 30 min chat which was very inspiring and enlightening.
  • Watched Mariatta - Don’t be a robot, build the bot - PyCon 2019 (so many similarities with Django!). Recommended!

[nessita]

Week ending 2024-02-18 (Week 07)

Triaged

• #35170 (LocaleMiddleware unexpectedly causes messages to be consumed under certain circumstances) – Django - LocaleMiddleware unexpectedly causes messages to be consumed under certain circumstances (invalid)
• #35180 (PostgreSQL pattern ops indexes are dropped when changing between CharField and TextField) – Django - PostgreSQL pattern ops indexes are dropped when changing between CharField and TextField (accepted)(duplicate)
• #35182 (Add support for additional HTML attributes to json_script template tag) – Django - Add support for additional HTML attributes to json_script template tag (wontfix)
• #35189 (Accessibility issues with collapsed fieldsets in admin forms) – Django - Accessibility issues with collapsed fieldsets in admin forms (accepted)
• #35187 (@sensitive_variables/sensitive_post_parameters decorators crash with .pyc-only builds.) – Django - Django 5.0+ doesn’t work with pyc files only (accepted)
• #35190 (django with postgresql is incompatible with pypy) – Django - django with postgresql is incompatible with pypy (invalid)(duplicate)

Reviewed

• https://github.com/django/django/pull/17338 - Accessibility guidelines for all contributors
• Made Group model get inherited from AbstarctGroup #29748 by htabar · Pull Request #17820 · django/django · GitHub - Made Group model get inherited from AbstarctGroup
• Fixed #35173 -- Reallowed filtering with __isnull on foreign keys not listed in list_filters. by Hisham-Pak · Pull Request #17844 · django/django · GitHub - Fixed #35173 – Fixed ModelAdmin.lookup_allowed() for lookups on foreign keys when not included in ModelAdmin.list_filter.
• Added a Pull Request Template by erosselli · Pull Request #17856 · django/django · GitHub - Added a Pull Request Template
• Fixed #34429 -- Allowed setting unusable passwords for users in the auth forms. by fsbraun · Pull Request #16942 · django/django · GitHub - Fixed #34429 – Allowed setting unusable passwords for users in the auth forms…
  • More iterations on this one, but is very close to being merged!

Authored

• Added GitHub Actions to create and check for reminders in pull requests. by nessita · Pull Request #17852 · django/django · GitHub - Added GitHub Actions to create and check for reminders in pull requests.
• Sharing password management functionality within auth forms

Other/Misc

• More fellowship conversations! Call for Django Fellow applicants closes soon.
• Started planning for DjangoCon Europe attendance!
• Watched Carlton’s talk about Know Your Limits. Super super recommended!

[nessita]

Week ending 2024-02-25 (Week 08)

Intense week! I tried to push forward as many PRs as I could, mainly because next week (week 9) I’ll be “OoO” (Out of the Office). Summer school for the kids ended last Friday, and “regular” school doesn’t start until the 4th, so I need to take the week off. We’re trying to make the best of the situation by organizing a family trip!

Triaged

• #35239 (FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox) – Django - FilteredSelectMultiple (filter_horizontal) initial selections reset when refreshing in Firefox (needsinfo)(duplicate)
• #35240 (Django doesn't set Postgres timezone to UTC when using psycopg3) – Django - Django doesn’t set Postgres timezone to UTC when using psycopg3 (needsinfo)
• #35243 (Add easy access to error codes in forms) – Django - Add easy access to error codes in forms (wontfix)
• #35241 (Cache Model._meta.get_parent_list()) – Django - Cache Model._meta.get_parent_list() (accepted)
• #35246 (Make Field.unique a plain attribute) – Django - Make Field.unique a plain attribute (accepted)

Reviewed

• Refs #30950, Refs #35187 -- Added tests for byte-compiled Django to daily builds. by bigfootjon · Pull Request #17870 · django/django · GitHub - Added pyc-only test to daily builds
• Refs #34900 -- Fixed CommandTypes.test_help_default_options_with_custom_arguments test on Python 3.13+. by felixxm · Pull Request #17891 · django/django · GitHub - Refs #34900 – Fixed CommandTypes.test_help_default_options_with_custom_arguments test on Python 3.13+.
• https://github.com/django/django/pull/16942 - Fixed #34429 – Allowed setting unusable passwords for users in the auth forms.
  • Thank you @fsbraun for your patience! I’m very happy this is now merged in main and it will be a new feature available in 5.1.
  • Also Thank you @accessibility team for your reviews and advice.
• Fixed #29942 -- Used linkcode sphinx extension instead of viewcode. by smithdc1 · Pull Request #17613 · django/django · GitHub - Fixed #29942 – Used linkcode sphinx extension instead of viewcode.
• Fixed #34806 -- Made the cached_db backend resilient to cache backend errors. by sulabhkatila · Pull Request #17220 · django/django · GitHub - Fixed #34806 – Made the cached_db backend resilient to cache backend errors.
• Fix #34746: Add a size limit for variable size when pretty printing exception report by keerthivasansa · Pull Request #17809 · django/django · GitHub - Fix #34746: Add a size limit for variable size when pretty printing exception report
• Fixed #35241 -- Cached model's full parent list. by adamchainz · Pull Request #17893 · django/django · GitHub - Fixed #35241 – Cached model’s Options.parent_list.
• Fixed #34643 -- Move admin form labels to a more accessible place by hrushikeshrv · Pull Request #16975 · django/django · GitHub - Fixed #34643 – Move admin form labels to a more accessible place

Authored

• Make the system check look at the types of settings? - #20 by nessita
• Added GitHub Actions to create and check for reminders in pull requests. by nessita · Pull Request #17852 · django/django · GitHub - Added GitHub Actions to create and check for reminders in pull requests.

Other/Misc

• Attended the Djangonauts session “Let’s become confident about Django documentation, right now”. Daniele Procida spoke about how to get confident with documentation, especially the Django one. Great stuff! I’m looking forward to the PRs derived from the group analysis.
• Security reports/patches review.

[nessita]

Week ending 2024-03-03 (Week 09)

Holidays!

I did meet with Çağıl (DSF vice president) and Mariusz for our monthly catch up.

[nessita]

Week ending 2024-03-10 (Week 10)

Triaged

• #35252 (Optimize django.urls.resolvers._route_to_regex()) – Django - Optimize django.urls.resolvers._route_to_regex() (accepted)
• #35270 (Optimize Model._meta._property_names) – Django - Optimize Model._meta._property_names (accepted)
• #35273 (AdminFileWidget renders two elements with the same ID) – Django - AdminFileWidget renders two elements with the same ID (accepted)
• #35272 (Django Admin - changing input to <select> tag using ModelChoiceField posts an Object(1) in the form) – Django - Django Admin - changing input to <select> tag using ModelChoiceField posts an Object(1) in the form (invalid)
• #35282 (ProgrammingError when admin.ShowFacets.ALWAYS and filter in list_filter of type SimpleListFilter on search.) – Django - ProgrammingError when admin.ShowFacets.ALWAYS and filter in list_filter of type SimpleListFilter on search. (duplicate)
• #35281 (Use HTTP 413 status code for RequestDataTooBig) – Django - Use HTTP 413 status code for RequestDataTooBig (accepted)
• #35284 (PositiveIntegerField description is confusing) – Django - PositiveIntegerField description is confusing (invalid)
• #35278 (`ngettext` result can be possibly undefined.) – Django - ngettext result can be possibly undefined. (accepted)
• #35285 (Optimize ForeignObject._check_unique_target) – Django - Optimize ForeignObject._check_unique_target (accepted)

Reviewed

• Added a Pull Request Template by erosselli · Pull Request #17856 · django/django · GitHub - Added a GitHub pull request template.
• Re-chartering the Fellowship-WG by jacobian · Pull Request #15 · django/dsf-working-groups · GitHub - Re-chartering the Fellowship-WG
  • This one took a while, I wanted to get the words right to match my view and how I feel about the role.
• Refs #35030 -- Added more tests for @user_passes_test decorator. by felixxm · Pull Request #17943 · django/django · GitHub - Refs #35030 – Added more tests for @user_passes_test decorator.
• Fixed typos in docstrings and docs. by cuinix · Pull Request #17942 · django/django · GitHub - remove repetitive words

Authored

• New asserts to make it easier make it easier to work with html forms - #2 by nessita

Other/Misc

• Deep dive on Storage’s base class in preparation for a possible security release.
  • Chat with Carlton, it was so very helpful to get more context!
• Chased and bought flight tickets to go to DjangoCon EU

[nessita]

Week ending 2024-03-17 (Week 11)

Triaged

• #35288 (login_required / user_passes_test redirects back to POST-only view) – Django - login_required / user_passes_test redirects back to POST-only view (wontfix)
• #35292 (Restore autofocus functionality to admin search box within popup interface) – Django - Restore autofocus functionality to admin search box within popup interface (invalid)
• #35298 (LANGUAGE_CODE: zh-Hant does not work for some translations on the admin site.) – Django - LANGUAGE_CODE: zh-Hant does not work for some translations on the admin site. (invalid)
• #35278 (`ngettext` result can be possibly undefined.) – Django - ngettext result can be possibly undefined. (accepted)

Reviewed

• Increased test coverage for Storage related file name validation (set of 3 isolated commits). by nessita · Pull Request #17972 · django/django · GitHub - Increased test coverage for Storage related file name validation (set of 3 isolated commits).
• Fixed #34789: `filter_horizontal` duplicates entries in "Chosen" column after instance is added via in another field using the "plus" JS action by devin13cox · Pull Request #17897 · django/django · GitHub - Fixed #34789: filter_horizontal duplicates entries in “Chosen” column after instance is added via in another field using the “plus” JS action
  • Deep dive on the Javascript code in RelatedObjectLookups.js. There are more issues to be tackled in this logic which I described in the PRs, will create tickets next week for those.

Authored

• Increased test coverage for Storage related file name validation (set of 3 isolated commits). by nessita · Pull Request #17972 · django/django · GitHub - Increased test coverage for Storage related file name validation (set of 3 isolated commits).
  • This is a continuation of the research from last week about Storage’s handling of file names.

Other/Misc

• Admin customization back and forth in Fixed #34982 -- Fixed admin's read-only password widget and help text… · django/django@729266c · GitHub

[nessita]

Week ending 2024-03-24 (Week 12)

Triaged

• #35289 (Chunked transfer encoding is not handled correctly by MultiPartParser) – Django - Chunked transfer encoding is not handled correctly by MultiPartParser (accepted)
• #35306 (Improve documentation for the various date format settings) – Django - Improve documentation for the various date format settings (accepted)
• #35310 (Optimize automatic JSON encoding of data in test client) – Django - Optimize automatic JSON encoding of data in test client (wontfix)
• #35308 (FileNotFoundError escapes from run_formatters()) – Django - FileNotFoundError escapes from run_formatters() (accepted)
• #35323 (Fix FileExistsError in django/core/files/move.py.) – Django - Fix FileExistsError in django/core/files/move.py. (accepted)
• #35324 (Postgres Extensions Not Available) – Django - Postgres Extensions Not Available (invalid)

Reviewed

• Fixed #35319 -- Move the link to add a related object inside the .selector-available column for FilteredSelectMultiple by hrushikeshrv · Pull Request #17996 · django/django · GitHub - Fixed #35319 – Move the link to add a related object inside the .selector-available column for FilteredSelectMultiple
• #35323 (Fix FileExistsError in django/core/files/move.py.) – Django - Fix FileExistsError in django/core/files/move.py.

Authored

• Django 5.1 release - status and next steps

Other/Misc

• More security-related work.
• Updated the 5.1 schedule.

[nessita]

Week ending 2024-03-31 (Week 13)

Triaged

• #35326 (OverwritingStorageTests fail if a TemporaryUploadedFile is used) – Django - OverwritingStorageTests fail if a TemporaryUploadedFile is used (accepted)
• #35328 (Improve CSRF Origin checking messaging) – Django - Improve CSRF Origin checking messaging (accepted)
• #35335 (Update "Enabling the sites framework" documentation to reiterate the ability to use `get_current_site`) – Django - Update “Enabling the sites framework” documentation to reiterate the ability to use get_current_site (accepted)
• #35337 (argument of type 'NoneType' is not iterable, when show facets and change_view is overwritten in ModelAdmin) – Django - argument of type ‘NoneType’ is not iterable, when show facets and change_view is overwritten in ModelAdmin (invalid)
• #35338 (Behaviour change in URL patterns.) – Django - Behaviour change in URL patterns. (invalid)
• #35339 (Ordering and filtering a Postgres ArrayAgg with parameters inverts SQL param order) – Django - Ordering and filtering a Postgres ArrayAgg with parameters inverts SQL param order (accepted)

Reviewed

• Fixed #29942 -- Used linkcode sphinx extension instead of viewcode. by smithdc1 · Pull Request #17613 · django/django · GitHub - Fixed #29942 – Used linkcode sphinx extension instead of viewcode.
• Fixed #35329 -- Fixed migrations crash when adding partial unique constraints with nulls_distinct. by felixxm · Pull Request #18022 · django/django · GitHub - Fixed #35329 – Fixed migrations crash when adding partial unique constraints with nulls_distinct.
• Fixed #34977: Make change password form reachable through button by fsbraun · Pull Request #17489 · django/django · GitHub - Fixed #34977: Make change password form reachable through button
• Fixed #35331 Adding a new related entry using the + sign from M2M now updates related lists. by devin13cox · Pull Request #18026 · django/django · GitHub - Fixed #35331 Adding a new related entry using the + sign from M2M now updates related lists.
• Fixed #35335 -- Updated "Enabling the sites framework" docs to reiterate usage of get_current_site. by sdarwin · Pull Request #17977 · django/django · GitHub - Fixed #35335 – Updated “Enabling the sites framework” docs to reiterate usage of get_current_site.
• Fixed a typo in the signals documentation. by matthiask · Pull Request #18029 · django/django · GitHub - Fixed typo in the signals documentation.
• Restored django.db.models.F import in final code snippet added at the beginning of tutorial 4. by EndoTaishi · Pull Request #18032 · django/django · GitHub - Restored django.db.models.F import in final code snippet added at the beginning of tutorial 4.

Authored

• #35333 (Template tag `unlocalize` does not work with `date` and `time` filters.) – Django - Template tag unlocalize does not work with date and time filters.
• Added a data point to Some cache tests are flaky.

Other/Misc

• Tried to reactivate efforts in these two PRs, which are similarly blocked when outputting unicode chars to the Windows stdout:
  • Refs #34976 -- Print directory structure after startapp and startproject by TobeTek · Pull Request #17838 · django/django · GitHub - Refs #34976 – Print directory structure after startapp and startproject
  • Refs #34976 -- Provide feedback when startapp and startproject are called by salvo-polizzi · Pull Request #17722 · django/django · GitHub - Refs #34976 – Provide feedback when startapp and startproject are called
  • Feature request: startproject and startapp should provide feedback - #11 by nessita
• Mariusz goodbye call!
• Monthly sync with Çağil and fellows, we welcomed Sarah!

[nessita]

Week ending 2024-04-07 (Week 14)

Triaged

• #35347 (Clarify choice_set attribute in tutorial 2) – Django - Clarify choice_set function in tutorial 2 (accepted)
• #35351 ("RuntimeError: Event loop is closed" when using aiomysql with Django async views) – Django - “RuntimeError: Event loop is closed” when using aiomysql with Django async views (invalid)
• #35353 (SelectFilter2.js puts the label for Django Admin filter fields in the wrong place) – Django - SelectFilter2.js puts the label for Django Admin filter fields in the wrong place (worksforme)

Reviewed

• Fixed #35344 -- Corrected output_field of resolved columns of table alias for GeneratedFields. by us77ipis · Pull Request #18034 · django/django · GitHub - Fixed #35344, Refs #34838 – Corrected output_field of resolved columns for GeneratedFields in aliased tables.
• Fixed #35347 -- Clarified choice_set attribute in tutorial 2. by AntWarden81 · Pull Request #18038 · django/django · GitHub - Fixed #35347 – Updated tutorial02.txt to clarify choice_set function
• Fixed Ticket #35330 (bug): The update of related objects fails in the admin when the related model is camel case. by devin13cox · Pull Request #18025 · django/django · GitHub - Fixed #35330 – Fixed the update of related widgets when the referenced model is camel case named.
• Fixed #35336 -- Addressed crash when adding a GeneratedField with % literals. by charettes · Pull Request #18027 · django/django · GitHub - Fixed #35336 – Addressed crash when adding a GeneratedField with % literals.
• Early adopt UTF-8 Mode on Windows. by smithdc1 · Pull Request #18041 · django/django · GitHub - Early adopt UTF-8 Mode on Windows.
• Refs #31710 -- Fixed multiple file upload documentation. by adamchainz · Pull Request #18044 · django/django · GitHub - Refs #31710 – Fixed multiple file upload documentation.
• Fixed #35354 -- Simplified ASGIRequest path handling. by carltongibson · Pull Request #18050 · django/django · GitHub - Fixed #35354 – Simplified ASGIRequest path handling.
• [5.0.x] Refs #35336 -- Fixed SchemaTests.test_add_generated_field_contains() test on PostgreSQL. by felixxm · Pull Request #18051 · django/django · GitHub - [5.0.x] Refs #35336 – Fixed SchemaTests.test_add_generated_field_contains() test on PostgreSQL.

Authored

• Added EOL date for Django 3.2 and moved it to Unsupported releases table. by nessita · Pull Request #1511 · django/djangoproject.com · GitHub - Added EOL date for Django 3.2 and moved it to Unsupported releases table.

Other/Misc

• Multiple chat sessions for onboarding our new fellow @sarahboyce
  • Pair programmingreleasing of Django 5.0.4
  • Chat about All Security Things.
  • Review of New Feature branches pending review.
• Various conversations about DjangoCon US.

[nessita]

Week ending 2024-04-14 (Week 15)

Triaged

• #35361 (SafeMIMEText.set_payload() crash on Python 3.11.9) – Django - SafeMIMEText.set_payload() crash on Python 3.11.9 (accepted)
• #35364 (AdminEmailHandler wastes work when ADMINS isn’t set) – Django - AdminEmailHandler wastes work when ADMINS isn’t set (accepted)
• #35368 (Postgres schema test failure locally) – Django - Postgres schema test failure locally (duplicate)
• #29748 (Add AUTH_GROUP_MODEL setting to swap the group model) – Django - Add AUTH_GROUP_MODEL setting to swap the group model (wontfix)

Reviewed

• Fixed #35350 -- Fixed save() with pk set on models with GeneratedFields. by sarahboyce · Pull Request #18058 · django/django · GitHub - Fixed #35350 – Fixed save() with pk set on models with GeneratedFields.
• Made postgresql.tests.Tests.test_connect_pool less flakey by increasing timeout value. by sarahboyce · Pull Request #18061 · django/django · GitHub - Made postgresql.tests.Tests.test_connect_pool less flakey by increasing timeout value.
• Early adopt UTF-8 Mode on Windows. by smithdc1 · Pull Request #18041 · django/django · GitHub - Early adopt UTF-8 Mode on Windows.
• Fixed #29942 -- Used linkcode sphinx extension instead of viewcode. by smithdc1 · Pull Request #17613 · django/django · GitHub - Fixed #29942 – Used linkcode sphinx extension instead of viewcode.
• Fixed path in Homebrew SpatiaLite docs. by adamchainz · Pull Request #18047 · django/django · GitHub - Fixed path in Homebrew SpatiaLite docs.
• Fixed -- Inconsistency in tutorial 7. by milinsoft · Pull Request #18062 · django/django · GitHub - [FIX] documentation tutorial07.txt.

Authored

• Updated docs for Django releases, including details about fetching and processing translations. by nessita · Pull Request #17545 · django/django · GitHub - Updated docs for Django releases, including details about fetching and processing translations.
  • Polish and merge. There was a misunderstanding on my part about the approval for this PR, Mariusz reached out and we are now aligned on the matter.
• Refs #35361 -- Added test for Email line length checks when dealing with surrogate pairs. by nessita · Pull Request #18057 · django/django · GitHub - Refs #35361 – Added test for Email line length checks when dealing with surrogate pairs.
• Refs #35361 -- Clarified release notes for 4.2.12 and 5.0.5. by nessita · Pull Request #18063 · django/django · GitHub - Refs #35361 – Clarified release notes for 4.2.12 and 5.0.5.
• Corrected alphabetical order of latest author added to AUTHORS. by nessita · Pull Request #18067 · django/django · GitHub - Corrected alphabetical order of latest author added to AUTHORS.
• Pinned GitHub Actions for reminders to specific versions. by nessita · Pull Request #18069 · django/django · GitHub - Pinned GitHub Actions for reminders to specific versions.

Other/Misc

• Following a few outages for www.djangoproject.com and code.djangoproject.com, spent some time with Tobias configuring synthetic monitoring checks for our sites and assisted where possible the Ops team in having the sites back up.
  • By the end of the week, I also configured the Grafana alerts for the website and trac to be send to the #ops Discord channel, to the #djangoproject-uptime channel in the DSF Slack, and to the ops@… mailing list.
• Read My Accessibility Review Checklist, completely recommended!
• Read multiple forum threads about Python and having the “UTF-8 mode” on by default.
• Multiple sessions pairing with @sarahboyce for doing merges, backports, and other syncs.
• Bought conference ticket for DjangoCon Europe!

[nessita]

Week ending 2024-04-21 (Week 16)

During this report week, I was a little sick on Thursday but luckily I recovered quickly. Resting is magical!

Triaged

• #35374 (UniqueConstraint (and potentially other constraints) validation is not run when using a form generated from `inlineformset_factory`) – Django - UniqueConstraint (and potentially other constraints) validation is not run when using a form generated from inlineformset_factory (invalid)
• #35377 (Add past and future validators for Date and DateTime fields) – Django - Add past and future validators for Date and DateTime fields (wontfix)
• #35154 (QuerySet implements `contains` but not `__contains__`) – Django - QuerySet implements contains but not __contains__ (wontfix again)
• #35380 (Have the images from docs/ref/contrib/admin/_images/ automatically generated.) – Django - Have the images from docs/ref/contrib/admin/_images/ automatically generated. (accepted)
• #35381 (Regression on json null value constraints in django 4.2) – Django - Regression on json null value constraints in django 4.2 (accepted)
• https://code.djangoproject.com/ticket/35386 - Incorrect checkbox help text alignment in multi-field rows (accepted)
• https://code.djangoproject.com/ticket/35387 - Django’s Spatialite backend throws errors with Spatialite 5.0.1 (duplicate)
• https://code.djangoproject.com/ticket/35382 - Low contrast background color for fieldset headings within inline formsets Remove unused CSS style .inline-related fieldset.module h3 (accepted)

Reviewed

• Refs #34406 Added support for GDAL curved geometries. by smithdc1 · Pull Request #18007 · django/django · GitHub - Refs #34406 Added support for GDAL curved geometries.
• Doc'd that PostgreSQL specifies CASCADE when dropping columns. by shangxiao · Pull Request #18066 · django/django · GitHub - Doc’d that PostgreSQL specifies CASCADE when dropping columns.
• Fixed #11593 -- Added testing to resuable apps intro by RaphaelKimmig · Pull Request #18018 · django/django · GitHub - Fixed #11593 – Added testing to resuable apps intro
• Removed fictional class 'extrapretty' from admin docs. by adamchainz · Pull Request #18075 · django/django · GitHub - Removed fictional class ‘extrapretty’ from admin docs.
• Fixed TypeError comparing datetime.datetime to datetime.date. by jsantos42 · Pull Request #18078 · django/django · GitHub - Fixed TypeError comparing datetime.datetime to datetime.date.
• Fixed #35356 -- Deferred self-referential foreign key fields adequately. by charettes · Pull Request #18055 · django/django · GitHub - Fixed #35356 – Deferred self-referential foreign key fields adequately.

Other/Misc

• Security reports analysis and follow up on existing conversations.
• Catch up with Sarah, we held a few sessions about making the contributor experience better, we are considering doing office hours and a few other options.

[nessita]

Week ending 2024-04-26 (Week 17)

I’m sending this report earlier since next week I plan to be off Monday and Tuesday , and also Wednesday which is Labour day in most places (except in US and Canada I believe). See you all next Thu!

Triaged

• #35394 (Warning if `postgres` database has been renamed (e.g. DigitalOcean managed)) – Django (needsinfo)
• #35399 (Reduce the "Case-When" sequence for a bulk_update when the values for a certain field are the same.) – Django (duplicate)
• #35407 (Cache Model._meta.swapped) – Django (accepted)
• #35409 (CheckbioxMultipleSelect widget is broken) – Django (worksforme)
• #35408 (Optimize post-migrate permission creation) – Django (accepted)

Reviewed

• Fixed #35392 -- Allowed importing aprefetch_related_objects from django.db.models. by jlost · Pull Request #18091 · django/django · GitHub
• Refs #34007 -- Added Q.referenced_based_fields property by shangxiao · Pull Request #18093 · django/django · GitHub
• Remove unintended blockquotes from documentation by minusf · Pull Request #18095 · django/django · GitHub
• Removed fictional class 'extrapretty' from admin docs. by adamchainz · Pull Request #18075 · django/django · GitHub
• Fixed #29942 -- Used linkcode sphinx extension instead of viewcode. by smithdc1 · Pull Request #17613 · django/django · GitHub
• Fixed #35189 -- Render admin collapsible fieldsets with <details>. by MHLut · Pull Request #17910 · django/django · GitHub
• Fixed 35339 - Fixed PostgreSQL aggregate order by and filter params order by camuthig · Pull Request #18045 · django/django · GitHub
• Fixed #35407 -- Cached model's Options.swapped. by adamchainz · Pull Request #18104 · django/django · GitHub
• Changed [yN] prompt to [y/N] in squashmigrations by dylancdavis · Pull Request #18102 · django/django · GitHub
• Fixed #20744 -- Removed generic kwargs from form Field class docs. by adamzap · Pull Request #18092 · django/django · GitHub
• Fixed #35405 -- Used @cached_property in FieldCacheMixin. by adamchainz · Pull Request #18101 · django/django · GitHub
• Refs #35339 -- Fixed source expressions in GeoAggregate on Oracle. by felixxm · Pull Request #18107 · django/django · GitHub

Authored

• Improved phrasing and removed bold text in the GitHub pull request template. by nessita · Pull Request #18098 · django/django · GitHub
• Pinned GitHub Actions for reminders to specific versions. by nessita · Pull Request #18069 · django/django · GitHub (finally landed after some modifications)

Other/Misc

• More security emails follow up, there were a couple of reports still waiting for an official response that I handled on Monday, plus more follow ups on Friday.
• Catch up with Cagil and Django Fellows.
• GSoC proposal review and ranking, mentor coordination, sync chat with Thibaud and Sarah B.