Contributing to Django

Django Internals Mentorship
1

Hi! I’d like to contribute to this Django tutorial page to fix a small bug. It would be my first open source contribution. Would someone kindly tell me how to submit a PR for this page: https://github.com/django/django/blob/574ee4023e15cfb195833edfbaed353f8021c62f/docs/intro/tutorial05.txt

2

PRs for small typos & trivial edits. Submit a ticket for larger issues.

May we ask what the bug is? :smiley:

3

Of course!

self.assertQuerySetEqual

should be:

self.assertQuerysetEqual

I hit some errors going through the tutorial and discovered it.

How can I make a PR for that specific page?

I apologize, I’m new :slight_smile:

4

assertQuerySetEqual is correct for the current version of Django. See these previous tickets: https://code.djangoproject.com/search?q=assertquerysetequal&noquickjump=1&ticket=on

5

I see. It seems as though my version is 4.0.6. That’s what got installed when I started the tutorial. Should I just upgrade my version?

6

I upgraded to latest version and assertQuerySetEqual still doesn’t work. Not sure what I’m doing wrong

7

It needs to be Django 4.2.x

8

If you are getting started with Open Source and you want to make your first PR, I would suggest referring to the following link to make your first Pull Request and make your first Open Source contribution.

Note : This comment is not regarding the issue being mentioned, rather it’s just to provide reference to a document which would help in submitting first patch. Hope this helps

1 Like
9

I upgraded to 4.2 and the issue remains. I even upgraded to 4.2.5 and it will still only work when using self.assertQuerysetEqual

When I change it to self.assertQuerySetEqual it doesn’t work.

It’s not a big deal for me to use the one that works, but I want to make sure I’m not doing anything wrong …

10

I suspect the upgrade didn’t work then :wink:

When you run Django’s runserver does it print something like:

Django version 4.2.5, using settings 'django_site.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.

If not then make sure your upgrade is done like so

pip install --upgrade Django==4.2.5

(you must pass --upgrade or -U)

11

It says this:

System check identified no issues (0 silenced).
September 24, 2023 - 19:28:43
Django version 4.2.5, using settings ‘mysite.settings’
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.