Django Fellow Report - Natalia - 2024

[nessita]

Week ending 2024-05-12 (Week 19)

The majority of my time this week was dedicated to the items in the ‘other/misc’ section, particularly focusing on releases and security reports-related activities.

Triaged

• #35439 (Hardcoded HTML in python code.) – Django (currently wontfix, though I’m on the fence for accepting this one)
• #35441 (Context autoescape parameter is not documented) – Django (accepted)
• #35414 (Issue with AsyncClient ignoring default headers compared to synchronous Client) – Django (accepted)
• https://code.djangoproject.com/ticket/35434 (wontfix)
• https://code.djangoproject.com/ticket/35442 (duplicate but may be accepted due to new comments)
• https://code.djangoproject.com/ticket/35423 (invalid)

Reviewed

• Corrected Slovak local name. by gardenerik · Pull Request #18017 · django/django · GitHub
• Fixed #35434 -- Advised validating unfetched instances before testing result cache. by jacobtylerwalls · Pull Request #18156 · django/django · GitHub

Authored

• Updated docs for releasing Django. by nessita · Pull Request #18141 · django/django · GitHub
• Added tests for Storage's generate_filename method. by nessita · Pull Request #18152 · django/django · GitHub

Other/Misc

• 6 hours pairing session with Sarah for her first release
• Releasing of Django 5.0.6 and 4.2.13 re-issuing 5.0.5 and 4.2.12 releases.
• Thorough review and catching up with unresolved security reports, including more work on potential fixes and patches.

[nessita]

Week ending 2024-05-19 (Week 20)

Triaged

• https://code.djangoproject.com/ticket/35447 - Request attribute upload handlers is immutable when method is POST (needsinfo)
• https://code.djangoproject.com/ticket/35448 - test --debug-sql SQL formatting is applied to more than the query (accepted)
• https://code.djangoproject.com/ticket/35452 - Unexpected results when Paginator’s orphans is equal or higher than the page size (accepted)

Reviewed

• https://github.com/django/django/pull/17792 - Fixed #31405 – Added LoginRequiredAuthenticationMiddleware force all views to require authentication by default.
• https://github.com/django/django/pull/17613 - Fixed #29942 – Restored source file linking in docs by using the Sphinx linkcode ext.
• https://github.com/django/django/pull/17910 - Fixed #35189 – Render admin collapsible fieldsets with <details>.
  • This one was both fun and time consuming!
  • Rabbit hole on trying to have “collapsible fieldsets inside TabularInline instances” (see ticket-35464).

Authored

• https://code.djangoproject.com/ticket/35456 - Fieldset title inside a collapsed StackedInline are h3 but on errors are shown as h2
• https://code.djangoproject.com/ticket/35464 - Fieldsets defined for TabularInlines are ignored

Other/Misc

• LOTS of Django 5.1 Feature Freeze preparations!

[nessita]

Week ending 2024-05-26 (Week 21)

Triaged

• https://code.djangoproject.com/ticket/35468 - Django with python 3.12 ImportError (invalid)

Reviewed

• https://github.com/django/django/pull/18167 - Refs #29942 – Avoided Python 3.9+ syntax in docs build.
• https://github.com/django/django/pull/18101 - Fixed #35405 – Used @cached_property in FieldCacheMixin.
• https://github.com/django/django/pull/17910 - Fixed #35189 – Render admin collapsible fieldsets with <details>.
• https://github.com/django/django/pull/17792 - Fixed #31405 – Added LoginRequiredAuthenticationMiddleware force all views to require authentication by default.
• https://github.com/django/django/pull/18195 - Fixed #35477 – Fixed field required validation in forms inheriting from SetPassword.
• https://github.com/django/django/pull/18190 - Fixed #35472 – Used temporary directory in test_imagefield.NoReadTests.

Authored

• https://github.com/django/django/pull/18185 - Refs #35380 – Updated outdated images in docs/ref/contrib/admin/_images/.
• https://forum.djangoproject.com/t/django-release-announcements/655/78
• https://github.com/pypa/trove-classifiers/pull/179 - Add Trove classifier for Django 5.1
• https://github.com/readthedocs/readthedocs.org/issues/11341 - Add 5.1.x version alias for Django docs.
• https://code.djangoproject.com/wiki/Version5.2Roadmap

Other/Misc

• Django 5.1 Feature Freeze! And subsequent Alpha release.
  • https://www.djangoproject.com/weblog/2024/may/22/django-51-alpha-1-released/

[nessita]

Week ending 2024-06-02 (Week 22)

Heads up! I’ll be attending DjangoCon EU next week, so my availability might be limited. Following that, I’ll be on holiday the week after .

Triaged

• https://code.djangoproject.com/ticket/35481 - assertTemplateUsed false positive (invalid)
• https://code.djangoproject.com/ticket/35489 - Misalignment in raw ID fields (accepted)

Reviewed

• https://github.com/django/jenkins-ansible/pull/96 - Updated PostgreSQL to 14.
• https://github.com/django/django/pull/18195 - Fixed #35477 – Fixed field required validation in forms inheriting from SetPassword.
• https://github.com/django/django/pull/18187 - Fixed #35467 – Replaced urlparse with urlsplit.
• https://github.com/django/django/pull/18204 - Refs #35059 – Adjusted test to use asyncio.Event for waiting.
• https://github.com/django/django/pull/18187 - Fixed #35467 – Replaced urlparse with urlsplit.
• https://github.com/django/django/pull/18210 - Made cosmetic edits to code snippets reformatted with blacken-docs.
• https://github.com/django/django/pull/16975 - Fixed #34643 – Move admin form labels to a more accessible place (high level review to confirm further steps)

Authored

• https://github.com/django/django/pull/18211 - Fixed #35380 – Automated the screenshot generation process for docs.
• https://github.com/django/django/pull/18216 - Updated release date for Django 5.0.7.
• https://code.djangoproject.com/ticket/35492 - Replace call to User.set_password with make_password in authenticate

Other/Misc

• Multiple security reports review, analysis and replies to reporters.
• DjangoCon EU imminent travel preparations!
• DjangoCon US travel planning!
• After the slowdown post Django 5.1 Feature Freeze, I started catching up with pending PRs/emails/topics.

[nessita]

Week ending 2024-06-09 (Week 23)

DjangoCon Europe week! This includes the Sprint days which were very intense and prolific.

Triaged

• https://code.djangoproject.com/ticket/35512 - problem while creating a new application (invalid)

Reviewed

• https://github.com/django/django/pull/18232 - Removed changing the port in the first part of the tutorial.
• https://github.com/django/django/pull/18233 - Fixed #35503 – Removed PHP references in tutorial 1.
• https://github.com/django/django/pull/18235 - Fixed #35502 – Changed directory name of mysite in tutorial.
• https://github.com/django/django/pull/18238 - Replacing the old concept of ‘patch’ by ‘pull request’ or ‘contribution’
• https://github.com/django/django/pull/18240 - Fixed 35506 – Rewrite confusing ‘URLconf’ references in the Tutorial pt.1
• https://github.com/django/django/pull/18242 - Startproject tutorial : Removed files explained after django-admin startproject mysite.

Week ending 2024-06-16 (Week 24)

Holidays!

[nessita]

Week ending 2024-06-23 (Week 25)

Triaged

• https://code.djangoproject.com/ticket/35530 - django.contrib.auth.login inconsistently guards request.user (invalid)
• https://code.djangoproject.com/ticket/35529 - Have the template tag query_string support multiple arguments and arguments of type Mapping[str, Any] (accepted)
• https://code.djangoproject.com/ticket/35538 - GeometryFilter Causes GDALException (needsinfo)
• https://code.djangoproject.com/ticket/35541 - Admin changelist total row css issue (accepted)
• https://code.djangoproject.com/ticket/35540 - Admin login form padding issue (accepted)
• https://code.djangoproject.com/ticket/35545 - Fix create_permissions LookupErrors (accepted)
• https://code.djangoproject.com/ticket/35531 - BaseModelFormSet.clean() recursively triggers is_valid() which may cause problems when is_valid() was overriden (invalid)
• https://code.djangoproject.com/ticket/35542 - BoundField’s label and help_text and renderer should be properties not class members (needsinfo)

Reviewed

• https://github.com/django/django/pull/18259 - Fixed #22712 – Avoided name shadowing of “all” in findstatic command.
• https://github.com/django/django/pull/18243 - Changed the order to highlight the success of the action after starting the development server
• https://github.com/django/django/pull/18290 - Updated tutorial images.
• https://github.com/django/django/pull/18288 - Cleaned up EmailMultiAlternatives docs.
• https://github.com/django/django/pull/18295 - Fixed Number.str() crash when float/decimal_value is None.

Authored

• https://code.djangoproject.com/ticket/35546 - Modernize contributing pages to align with current requirement of having an accepted ticket for non trivial changes

Other/Misc

• Slow catch up with a considerable backlog of emails and messages.
• Follow up on multiple security reports. This includes development of patches, PR reviews and bootstrapping the security release machinery.
• Booked accommodation for DjangoCon US!

[nessita]

Week ending 2024-06-30 (Week 26)

Triaged

• https://code.djangoproject.com/ticket/35556 - The checkbox of a BooleanField is displayed before field’s name (duplicate)
• https://code.djangoproject.com/ticket/35562 - get_FOO_display() method gives choice instead of choice.label for unbound (not saved) model instances with enumeration choices (invalid)
• https://code.djangoproject.com/ticket/35561 - Model.save()/asave() deprecation allows duplicate arguments (accepted)
• https://code.djangoproject.com/ticket/35560 - Model.full_clean() errors with GeneratedField and UniqueConstraint or CheckConstraint (accepted)
• https://code.djangoproject.com/ticket/35555 - Add additional middleware checks for django.contrib.auth (wontfix)
• https://code.djangoproject.com/ticket/35563 - Fetch related user permissions if “user_permissions” are added in add_fieldsets on Admin Panel (wontfix)

Reviewed

• https://github.com/django/django/pull/17806 - Migrated setuptools configuration to pyproject.toml.
• https://github.com/django/django/pull/18304 - Fixed #35554, Refs #35060 – Improved *args parsing in Model.save()/asave().
• https://github.com/django/django/pull/18290 - Updated screenshots in tutorial.
• https://github.com/django/django/pull/18308 - Fixed #35558 – Made inline header styling visually stronger than its content.
• https://github.com/django/djangoproject-ansible/pull/109 - Added daily reloading of uwsgi.
• https://github.com/django/django/pull/18259 - Fixed #22712 – Avoided name shadowing of “all” in findstatic command.
• https://github.com/django/django/pull/18321 - Refs #22712 – Corrected deprecation django.contrib.staticfiles.finders.find()'s all argument.

Authored

• https://github.com/django/django/pull/18313 - Fixed #35561 – Made *args and **kwargs parsing more strict in Model.save()/asave().
• https://github.com/django/django/pull/18319 - Refs #35561 – Renamed Model.save()/asave() helper to a more specific name.

Other/Misc

• Security reports follow up.

[nessita]

Week ending 2024-07-07 (Week 27)

Triaged

• https://code.djangoproject.com/ticket/35571 - TypeError in assertTemplateUsed when using pathlib.Path as template_name (invalid)
• https://code.djangoproject.com/ticket/35570 - groups not shown in iOS (needsinfo)
• https://code.djangoproject.com/ticket/35542 - BoundField’s label and help_text and renderer should be properties not class members (worksforme)
• https://code.djangoproject.com/ticket/35579 - Run the development server (python manage.py runserver) creating http://127.0.0.1:8000/login/ in your browser. (invalid)
• https://code.djangoproject.com/ticket/35578 - Customizing username_validator in custom User model extending django.contrib.auth.models.AbstractUser doesn’t work (invalid)
• https://code.djangoproject.com/ticket/35535 - Provide new template tag to capture internal block output as a template variable (“simple block tag”) (accepted)

Reviewed

• https://github.com/django/django/pull/18328 - Fixed typo in source file linking Sphinx extension.
• https://github.com/django/django/pull/18324 - Fixed #23790: Added warning to AppConfig.label docs reference.
• https://github.com/django/django/pull/18330 - Fixed #35566 – Added get_FOO_display() support for GeneratedFields.
• https://github.com/django/django/pull/18331 - Fixed #35571 – Store template_names as string
• https://github.com/django/django/pull/18253 - Relocated database setup details to install docs to simplify tutorial 2.
• https://github.com/django/django/pull/18264 - Replaced usage of “patch” with more precise terms in contributing docs.
• https://github.com/django/django/pull/18224 - Removed outdated note about limitations in Clickjacking protection.
• https://github.com/django/django/pull/18240 - Fixed 35506 – Clarified confusing ‘URLconf’ references in tutorial 1.

Other/Misc

• Intense preparation work for incoming security release for next week. Finalized patches, tested backports, posted announcement.
• Sarah and I worked on and finalized a document outlining the Django Fellowship Program, including a list of proposed sprint topics for EuroPython. This material will support the DSF booth at the event and can also be used to facilitate further discussions involving the Fellowship.

[nessita]

Week ending 2024-07-14 (Week 28)

Triaged

• https://code.djangoproject.com/ticket/35542 - BoundField’s label and help_text and renderer should be properties not class members (worksforme again)
  • Also allocated some time to carefully craft a detailed response to the reporter, aiming to address their concerns and promoting effective community contributions and alignment.
• https://code.djangoproject.com/ticket/35583 - asgiref.sync.sync_to_async cannot be affected by close_old_connections (needsinfo)
• https://code.djangoproject.com/ticket/35573 - CORS Policy Error with Specific Data in React and Django Application (invalid reiterated)
• https://code.djangoproject.com/ticket/35588 - Migrating primary key to UUIDField causes serializer validation issues (invalid)
• https://code.djangoproject.com/ticket/35589 - AlterField should raise an error when changing primary key (needsinfo)

Reviewed

• https://github.com/django/django/pull/18346 - Fixed #35083 – Make method_decorator work with async functions.
• https://github.com/django/django/pull/18353 - Fixed #35585 – Corrected Query.exists() call in Query.has_results().
• https://github.com/django/django/pull/18240 - Fixed 35506 – Clarified initial references to URLconf in tutorial 1.
• https://github.com/django/django/pull/18364 - Refs #35506 – Reverted “global URLconf” to “root URLconf” in tutorial 1.
• https://github.com/django/django/pull/18357 - Doc’d purpose of tuple() in SQLCompiler.get_from_clause().

Authored

• Fixed stable/5.1.x docs build error following up https://github.com/django/django/pull/18339

Other/Misc

• Watched “The Hard Parts of Open Source” by Evan Czaplicki following the recommendation from Sarah. It’s about open source and the challenges around building/maintaining a healthy community. I was happily amazed by the content and quality of the talk, and also the speaker has great communication skills which makes it quite entertaining. I fully recommend it!
• Attended the Djangonaut session “Django core demystified” by Sarah Boyce, amazing and highly recommended talk!
• Read and reflected on: Inclusive communications expectations in Python spaces - PSF
• Chat with Jacob Kaplan Moss and Sarah about The Django Fellowship [Program|Working Group].
• Wrote detailed instructions to reproduce Ticket #25947 – Query’s str() method fails when ‘default’ database is empty.

[nessita]

Week ending 2024-07-21 (Week 29)

Triaged

• https://code.djangoproject.com/ticket/35612 - Emphasise user responsibility within “Reporting security issues” to detail invalid reports (accepted)
• https://code.djangoproject.com/ticket/35598 - Add SearchInput widget (accepted)
• https://code.djangoproject.com/ticket/35599 - Add ColorInput widget (accepted)
• https://code.djangoproject.com/ticket/35600 - Add RangeInput widget (duplicate)
• https://code.djangoproject.com/ticket/35601 - Add TelInput widget (accepted)
• https://code.djangoproject.com/ticket/35492 - Replace call to User.set_password with make_password in authenticate (revisited, asked for broader feedback, wontfix)

Reviewed

• https://github.com/django/django/pull/18323 - Refs #10941 – Renamed query_string template tag to querystring.
• https://github.com/django/django/pull/18357 - Doc’d purpose of tuple() in SQLCompiler.get_from_clause().
• https://github.com/django/django/pull/18188 - Updated docs to prefer QuerySet.none() as a default for dynamic queryset form field kwargs
• https://github.com/django/django/pull/18346 - Fixed #35083 – Made method_decorator work with async functions.
• https://github.com/django/django/pull/18365 - [DRAFT] #32577 autofield allow non ints, add uuid auto (initial high level review)
• https://github.com/django/django/pull/18371 - Fixed #35604, Refs #35326 – Made FileSystemStorage.exists() behaviour independent from allow_overwrite.

Authored

• https://github.com/django/django/pull/18369 - Removed leftover KeyError handling after Query.tables attribute cleanup.
• https://github.com/django/django/pull/18372 - Refs #10941 – Reorganized querystring template tag docs.
• https://github.com/django/django/pull/18373 - Refs #10941 – Renamed test file test_query_string.py to test_querystring.py.
• https://github.com/django/django/pull/18378 - Built the Python version matrix for the Windows tests using the project config file.
• https://github.com/django/django/pull/18379 - [5.0.x] Built the Python version matrix for the Windows tests using the project config file.

Other/Misc

• Spent some time debugging CI failures on mariadb + Python 3.12. It was a CI specific issue which was fixed by Mariusz (thanks!).

[nessita]

Week ending 2024-07-28 (Week 30)

Triaged

• https://code.djangoproject.com/ticket/35622 - Make unittest ignore Django frames in tracebacks (accepted)
• https://code.djangoproject.com/ticket/35634 - Add Detailed Steps for Setting Up MySQL in Django Tutorials (wontfix)
• https://code.djangoproject.com/ticket/35633 - i found a bug in the documentation version 4.2 in Writing your first Django app, part 5 (invalid)

Reviewed

• https://github.com/django/django/pull/18371 - Fixed #35604, Refs #35326 – Made FileSystemStorage.exists() behaviour independent from allow_overwrite.
• https://github.com/django/django/pull/18353 - Fixed #35585 – Corrected Query.exists() call in Query.has_results().
• https://github.com/django/django/pull/18398 - Refs #29049 – Fixed isolation of BasicExpressionsTests._test_slicing_of_f_expressions() subtests.
• https://github.com/django/django/pull/18399 - Fixed #35622 – Made unittest ignore Django asserts in tracebacks.

Authored

• https://github.com/django/django/pull/18409 - Added dedicated test for invalid inputs in floatformat template filter tests.

Other/Misc

• DjangoCon US preparations:
  • Interview with Jason Judkins (DjangoCon US Marketing Chair).
  • Talk preparation.
• Django 5.1 release candidate is out!
  • https://www.djangoproject.com/weblog/2024/jul/24/django-51-rc1/
  • https://forum.djangoproject.com/t/django-release-announcements/655/81
  • https://forum.djangoproject.com/t/django-5-1-string-freeze-is-in-effect-translations-needed/33274
• Security related work:
  • Patches review.
  • Analysis of unanswered reports, replied to various reporters.

[nessita]

Week ending 2024-08-04 (Week 31)

Triaged

• https://code.djangoproject.com/ticket/35639 - Title of deletion confirmation page could be clearer (accepted)
• https://code.djangoproject.com/ticket/35642 - After Upgrading from Django 2.2.28 to Django 3.2.25, JSONField is returning data in string rather than dictionary/list (invalid)
• https://code.djangoproject.com/ticket/35641 - Pattern matching on model objects (wontfix)
• https://code.djangoproject.com/ticket/35648 - SafeString and overriding addition do not work well together (accepted)
• https://code.djangoproject.com/ticket/35644 - AdminDateWidget and AdminTimeWidget do not have admin/js/core.js in their Media (duplicate)
• https://code.djangoproject.com/ticket/35650 - Multi select checkboxes with shift key is not working in TabularInlineAdmin (accepted)

Reviewed

• https://github.com/django/django/pull/18418 - Referenced joining the triage and review team as motivation to do PR reviews.
• https://github.com/django/django/pull/18422 - Fixed #35639 – Improved admin’s delete confirmation page title.
• https://github.com/django/django/pull/18434 - Fixed #35648 – Extended SafeString to support __radd__.
• https://github.com/django/django/pull/18424 - Fixed #35440 – Updated parse_header_parameters logic.
• https://code.djangoproject.com/ticket/35650 - Fixed #35650 - Added multi select checkboxes with shift in TabularInlineAdmin
• https://github.com/django/django/pull/18431 - Fixed #35643 – Fixed a crash when ordering by a reference containing “__”.
• https://github.com/django/django/pull/18441 - Refs #35601, Refs #35599 – Made cosmetic edits to TelInput/ColorInput docs.

Authored

• https://github.com/django/django/pull/18428/ - Removed GitHub Actions for creating and checking reminders.
• https://github.com/django/django/pull/18429 - Extended script to manage translations to support fetching new translations since a given date.
• https://github.com/django/django/pull/18430 - [5.1.x] Updated translations from Transifex.
• https://code.djangoproject.com/ticket/35645 - Inline H3 header style is visually stronger than the page’s H1 (admin, light theme).
• https://code.djangoproject.com/ticket/35646 - SafeExceptionReporterFilter should filter settings and headers such as HTTP_AUTHORIZATION
• https://github.com/django/django/pull/18432 - Fixed #35645, Refs #35558 – Made H1 styling visually stronger than other headings in the admin.
• https://github.com/django/django/pull/18433 - Fixed #35646 – Extended SafeExceptionReporterFilter.hidden_settings to treat AUTH as a sensitive match.
• https://github.com/django/django/pull/18439 - Fixed #35645, Refs #35558 – Added “medium” color in the admin CSS to improve accessibility of headings.

Other/Misc

• Intense week in terms of security patches review and security release preparation (scheduled for Tue Aug 6th).
• Django 5.1 final release preparation work (scheduled for Wed Aug 7th).

[nessita]

Week ending 2024-08-11 (Week 32)

Triaged

• https://code.djangoproject.com/ticket/35661 - test_too_many_digits_to_render test fails with PyPy3.10 7.3.16 (accepted)
• https://code.djangoproject.com/ticket/35662 - running tests now requires static files to be generated when using ManifestStaticFilesStorage (needsinfo)(invalid)

Reviewed

• https://github.com/django/django/pull/18447 - Used :pypi: role in docs where appropriate.
• https://github.com/django/django/pull/18450 - Refs #373 - Added Field.is_set().
• https://github.com/django/django/pull/18235 - Fixed #35502 – Changed directory name of mysite in tutorial.
• https://github.com/django/django/pull/18422 - Fixed #35639 – Improved admin’s delete confirmation page title.
• https://github.com/django/django/pull/18236 - Documented that SessionMiddleware is required for admin.
• https://github.com/django/django/pull/18399 - Fixed #35622 – Made unittest ignore Django asserts in tracebacks.
• https://github.com/django/django/pull/18434 - Fixed #35648 – Extended SafeString to support radd.

Authored

• https://github.com/django/django/pull/18430 - [5.1.x] Updated translations from Transifex. (re-fetched and cleaned up translations, fixed test failure)
• https://github.com/django/djangoproject.com/pull/1606 - Django 5.1 final release tasks.
• https://github.com/django/django/pull/18461 - Added test for acheck_password() to ensure make_password is called for unusable passwords.

Other/Misc

• Django 5.1 final release!
  • Fetched latest translations from Transifex, polished the PR, landed, forward port to main.
  • Django 5.1 released | Weblog
• Pairing with Sarah for the Django 5.0.8 and 4.2.15 security releases. Well done @sarahboyce!
  • Django security releases issued: 5.0.8 and 4.2.15 | Weblog

[nessita]

Week ending 2024-08-18 (Week 33)

Triaged

• https://code.djangoproject.com/ticket/35666 - Stack level of deprecation warnings should be tested (accepted)
• https://code.djangoproject.com/ticket/35667 - Switch usage to skip_file_prefixes instead of stacklevel when it makes sense (accepted)
• https://code.djangoproject.com/ticket/35674 - Provide a check for DEFAULT_FILE_STORAGE (wontfix)
• https://code.djangoproject.com/ticket/35675 - Reduce impact of parsing crafted templates with repeat tags (accepted)
• https://code.djangoproject.com/ticket/35677 - Unexpected behaviour of Prefetch with queryset filtering on a through model (needsinfo)(accepted)
• https://code.djangoproject.com/ticket/35680 - Add default automatic imports to shell (accepted)

Reviewed

• https://github.com/django/django/pull/18434 - Fixed #35648 – Extended SafeString to support radd.
• https://github.com/django/django/pull/17809 - Fix #34746: Add a size limit for variable size when pretty printing exception report.
• https://github.com/django/django/pull/18458 - Marked missing part of warning footer for translation in SelectFilter2.js.
• https://github.com/django/django/pull/18450 - Refs #373 – Added Model._is_pk_set().
• https://github.com/django/django/pull/18235 - Fixed #35502 – Changed directory name of mysite in tutorial.
• https://github.com/django/django/pull/18349 - Fixed #32831 – marked flaky tests for retry on assertion failure.
• https://github.com/django/django/pull/18472 - Refs #35648 – Corrected release notes for SafeString.add() changes.
• https://github.com/django/django/pull/18481 - Made password validators callable.
• https://github.com/django/django/pull/18464 - Fixed #35666 – Documented stacklevel testing and adjusted test suite accordingly.
• https://github.com/django/django/pull/18368 - Fixed #35529 – Added support for dicts and multiple args in querystring.
• https://github.com/django/django/pull/18488 - Updated translations from Transifex.
• https://github.com/django/django/pull/18477 - Update ModelAdmin#save_model to properly set update_fields

Authored

• https://github.com/django/django/pull/18484 - Fixed #35678 – Reallowed extending auth’s UserCreationForm.
• https://github.com/django/django/pull/18487 - Refs #10941 – Added tests for querystring template tag.

Other/Misc

• DjangoCon US presentation work.
  • Talk announcement: https://2024.djangocon.us/news/introducing-keynote-natalia-bidart/

[nessita]

Week ending 2024-08-25 (Week 34)

Triaged

• https://code.djangoproject.com/ticket/35691 - Override translation (invalid)
• https://code.djangoproject.com/ticket/35693 - Password validators aren’t callable (accepted)
• https://code.djangoproject.com/ticket/35698 - Pluralised blocktranslate doesn’t translate (invalid)
• https://code.djangoproject.com/ticket/35706 - Improve admin add/change form top level errors for screen readers (accepted)

Reviewed

• https://github.com/django/django/pull/18481 - Fixed #35693 – Made password validators callable.
• https://github.com/django/django/pull/18400 - Fixed #35695 – Ensured FileFields use a storage pointing to a temp directory in model_fields tests.
• https://github.com/django/django/pull/18501 - Refs #35042 – Added missing skip to aggregation test.
• https://github.com/django/django/pull/18411 - Updated Sphinx source_suffix setting to use dictionary mapping.
• https://github.com/django/django/pull/18505 - fix: default url conf not shown when running under prefix
• https://github.com/django/django/pull/18498 - Fixed #35688 – Moved setting timezone and role to DatabaseWrapper class methods.
• https://github.com/django/django/pull/18511 - Added HTML email example prominently to email documentation (high level review only)

Authored

• https://github.com/django/django/pull/18503 - Sorted alphabetically forms list in docs/topics/auth/default.txt.
• https://github.com/django/django/pull/18509 - Added helper and refactored PasswordResetFormTest to unify email sending tests.

Other/Misc

• Security reports follow up, patch preparation and reviews.
• Prioritized work/reviews for release blocker issues.
• Progressed DjangoCon US talk slides.

[nessita]

Week ending 2024-09-01 (Week 35)

I wanted to let the community know that starting in September, I will be adjusting my work schedule. I’ll be dedicating my time to Fellow tasks from Monday to Thursday.

I’ll also be taking a few days off before DjangoCon US, where I’ll be attending and presenting . As a result, there may be a reduced pace in the second half of September.

Triaged

• https://code.djangoproject.com/ticket/35707 - Squash migrations in django.contrib.auth for better performance and nicer output (wontfix)
• https://code.djangoproject.com/ticket/35710 - search result always showing noresults (invalid)
• https://code.djangoproject.com/ticket/35709 - Command collectstatic should relay on checksums instead of modify time (duplicate)
• https://code.djangoproject.com/ticket/35716 - Undefined template variables on Admin’s add page templates when using fieldsets (accepted)

Reviewed

• https://github.com/django/django/pull/18501 - Added missing skips for supports_select_union and supports_sequence_reset.
• https://github.com/django/django/pull/18516 - Fixed typos in docs/howto/initial-data.txt.
• https://github.com/django/django/pull/18514 - Fixed #35660 – Provided fixtures during setUpClass phase of TransactionTestCase.
• https://github.com/django/django/pull/18463 - Refs #34609 – Fixed stack level of format_html() warning.
• https://github.com/django/django/pull/18464 - Fixed #35666 – Documented stacklevel testing and adjusted test suite accordingly.
• https://github.com/django/django/pull/18507 - Refs #34900 – Updated requirements for Python 3.13.
• https://github.com/django/django/pull/18519 - Fixed typo in docs/ref/models/expressions.txt.
• https://github.com/django/django/pull/18521 - Fixed #35716
• https://github.com/django/django/pull/18520 - Removed outdated note about lack of subquery support in MySQL.
• https://github.com/django/django/pull/18450 - Refs #373 – Added Model.is_pk_set().
• https://github.com/django/django/pull/18526 - Fixed #35716 – Fixed VariableDoesNotExist when rendering admin fieldsets.

Authored

• https://github.com/django/django/pull/18498 - Fixed #35688 – Moved setting timezone and role to DatabaseWrapper class methods. (This PR was originally from Sarah, but I picked it up to have the fix for the release blocker ready for the next release.)

Other/Misc

• Security release preparation (scheduled for September 3rd):
  • Finalized patches targeting main and all supported stable branches.
  • Merged and backported stub release notes for 5.1.1, 5.0.9 and 4.2.16.
  • Sent pre-notification email and posted announcement.

[nessita]

Week ending 2024-09-08 (Week 36)

Intense week! Among other things, the monthly release went out, including 2 security fixes. Upgrade quickly, stay current!

Triaged

• https://code.djangoproject.com/ticket/35727 - Add response.text_content to responses (accepted)
• https://code.djangoproject.com/ticket/35728 - Lazily compute assertion messages (accepted)
• https://code.djangoproject.com/ticket/35674 - Provide a check for settings removed (post deprecation) (revisited, now accepted)
• https://code.djangoproject.com/ticket/35726 - db.models.TextField.formfield() does not behave like CharField.formfield() when null=True (wontfix)
• https://code.djangoproject.com/ticket/35729 - How to serialize user profiles without natural keys? (invalid)
• https://code.djangoproject.com/ticket/35731 - Extend documentation about db_default and DatabaseDefault (accepted)
• https://code.djangoproject.com/ticket/35736 - Incorrect pluralization of model names in the admin panel (invalid)
• https://code.djangoproject.com/ticket/35734 - Tests fail with Postgres 16 and server side bindings (accepted)
• https://code.djangoproject.com/ticket/35735 - For python 3.9+ class property may not be accessible by Django’s template system (needsinfo)
• https://code.djangoproject.com/ticket/35737 - Clarify where models comes from to understand missing import statement in tutorial 7 (accepted)

Reviewed

• https://github.com/django/django/pull/18494 - Fixed #25706 – Removed inline JS from openlayers templates.
• https://github.com/django/django/pull/18539 - Refs #35730: Signed 'uid’ parameter instead of base64-encoding to prevent possible user count leakage
• https://github.com/django/django/pull/18343 - Fixed #35535 – Add simple block tag
• https://github.com/django/django/pull/18349 - Fixed #32831 -– Allowed cache tests to be retried via a new “retry” decorator.
• https://github.com/django/django/pull/18548 - Fixed #35737 – Clarified where “models” comes from in tutorial 7.
• https://github.com/django/django/pull/18315 - Updated instruction for deploying with Uvicorn and Gunicorn.
• https://github.com/django/django/pull/18542 - Fixed #35732 – Wrapped Postgresql Concat args in parenthesis to fix operator precedence bug.
• https://github.com/django/django/pull/18543 - feat: added JSON property to HTTPRequest Object
• https://github.com/django/django/pull/18545 - Fixed #35681 – Corrected geoip2 docs when describing GeoIP2Exception.
• https://github.com/django/django/pull/18543 - feat: added JSON property to HTTPRequest Object

Other/Misc

• Security reports triage and follow up.
• Engaged in CSP conversations:
  • https://forum.djangoproject.com/t/adding-csp-support-to-django/31526/6
• Completed Security and Bug fix release for 5.1.1, 5.0.9 and 4.2.16.
  • https://www.djangoproject.com/weblog/2024/sep/03/security-releases/
• DjangoCon US presentation progress. Getting nervous about this!

[nessita]

Week ending 2024-09-15 (Week 37)

As mentioned, week 38 (starting today) will be a short week for me since kid is at home due to spring holidays and also I have travel prep to do . Next week, DjangoCon US!

Triaged

• https://code.djangoproject.com/ticket/35753 - Problem installing Django (invalid)
• https://code.djangoproject.com/ticket/35742 - Apply UserAdmin add_form_template according to User model USERNAME_FIELD (accepted, re-triaged)

Reviewed

• https://github.com/django/django/pull/18450 - Refs #373 – Added Model.is_pk_set().
• https://github.com/django/django/pull/18543 - feat: added JSON property to HTTPRequest Object
• https://github.com/django/django/pull/18514 - Fixed #35660 – Provided fixtures during setUpClass phase of TransactionTestCase.
• https://github.com/django/django/pull/18534 - Fixed #35727 – Added HttpResponse.text property.
• https://github.com/django/django/pull/18564 - Refs #373 – Removed outdated comment in RelatedIn lookup.
• https://github.com/django/django/pull/18511 - Added example of email sending with additional capabilities to docs/topics/email.txt.
• https://github.com/django/django/pull/18552 - 35742: Apply UserAdmin add_form_template according to user model USERNAME_FIELD
• https://github.com/django/django/pull/18576 - Pinned Miniforge in benchmark workflow.

Other/Misc

• Engaged in forum topics.
  • Read https://buttondown.com/carlton/archive/evolving-djangos-authuser/ and I commented about it on the forum. Extremely recommended post!
  • Still pending to watch the linked talks and related posts.
• DjangoCon US final preparation:
  • Attended Sarah’s trial run of her presentation. This is definitely a MUST see!
  • Intense last-push for finalizing my presentation for DjangoCon US. Made a trial run for Sarah (thank you for your time, support and notes!). Applied improvements. Looking forward to this!

[nessita]

Week ending 2024-09-22 (Week 38)

Triaged

• https://code.djangoproject.com/ticket/35768 - Add a User Profile How-To (accepted)
• https://code.djangoproject.com/ticket/35767 - Adjust customizing user model docs (accepted)
• https://code.djangoproject.com/ticket/35770 - Improve recommendation for ignoring memcached-incompatible cache key warnings (accepted)
• https://code.djangoproject.com/ticket/35763 - Setting the auto increment value of a database model breaks when you add a new field to the model (invalid)
• https://code.djangoproject.com/ticket/35772 - Document models.Field.contribute_to_class (wontfix)

Reviewed

• https://github.com/django/django/pull/18552 - Fixed #35742 – Used USERNAME_FIELD’s verbose name in auth’s add_form template.
• https://github.com/django/django/pull/18585 - Improved test for TokenType.COMMENT by using correct block syntax in template tests.
• https://github.com/django/django/pull/18547 - Fixed #35735 – Restored access to subscribable class methods and properties in templates.
• https://github.com/django/django/pull/18566 - Fixed #35767 – Adjusted customizing user model docs.
• https://github.com/django/django/pull/18591 - Updated link with valid options for LANGUAGE_CODE in global_settings.py.
• https://github.com/django/django/pull/18590 - Handled slices in BaseChoiceIterator.
• https://github.com/django/django/pull/18544 - Fix None response serialisation in make_bytes used by response.content
• https://github.com/django/django/pull/18601 - Update config.py

Authored

• https://github.com/django/django/pull/18592 - Refs #35734 – Added new entry to scheduled tests workflow to test all supported PostgreSQL versions.

Other/Misc

• Engaged in forum conversations.
• DjangoCon US travel preparations.

[nessita]

Week ending 2024-09-28 (Week 39)

DjangoCon US!