Django Fellow Report - Natalia

[nessita]

Week ending 2023-09-03 (Week 35)

Triaged

• https://code.djangoproject.com/ticket/34803 - Nested OuterRef can raise AttributeError: ‘OuterRef’ object has no attribute ‘contains_over_clause’ (worksforme)(accepted)
• https://code.djangoproject.com/ticket/34806 - Make cached_db backend resilient to cache backend errors (accepted)

Reviewed

• https://github.com/django/django/pull/17081 - Refs #34712 – Added system check for staticfiles storage in STORAGES setting.
• https://github.com/django/django/pull/16012 - Fixed #12090 – Show admin actions on the edit pages too
• https://github.com/django/django/pull/17218 - Refs #34768 – Ignored lack of just_fix_windows_console() for colorama < 0.4.6.

Authored

• Resurfaced and chased reviews for: https://github.com/django/django/pull/16896 - Reorganized tutorial’s part 4 to better understand changes needed in URLConf.
• https://github.com/django/django/pull/17214 - Added support for callables on model fields’ choices.
• https://github.com/django/django/pull/17215 - Fixed #34807 – Avoided circular import between forms, models and utils’ choices.

Other/Misc

• Read reports and shared thoughts about the djangoproject.com website analysis work.
• Support for choices as mappings has been finally landed! Congrats Tom Forbes (@orf) and Nick Pope (@ngnpope).
  • This was my first big merge and I lost the co-authors. Sorry about that!
• Presented a talk in the Djangonauts space https://fosstodon.org/@djangonaut@indieweb.social/110985440401993749
• More work on DjangoCon US presentation.

[nessita]

Week ending 2023-09-10 (Week 36)

Triaged

• https://code.djangoproject.com/ticket/34813 - Docs miss note about invalid integrity with ManifestStaticFilesStorage (accepted)
• https://code.djangoproject.com/ticket/34817 - Boolean field doesn’t look good on django-admin (invalid)
• https://code.djangoproject.com/ticket/34819 - GenericForeignKey.get_prefetch_queryset() (needsinfo)(accepted)

Reviewed

• https://github.com/django/django/pull/17227 - Fixed #34813 – Doc’d how calculation of the integrity HTML attr needs to occur after collectstatic.
• https://github.com/django/django/pull/17186 - Modernized enum usage for choices enumeration types.
• https://github.com/django/django/pull/17226 - Fixed #34810 – Measured test coverage on django-admin commands.
• https://github.com/django/django/pull/17169 - WIP: Unforced AutoFields to be primary keys (high level pass)

Authored

• https://github.com/django/django/pull/17214 - Fixed #24561 – Added support for callables on model fields’ choices. (follow up)
  • https://discuss.python.org/t/why-functools-cache-or-lru-cache-does-not-seem-to-wraps-the-passed-function/32965
  • https://forum.djangoproject.com/t/callables-for-model-fields-choices/23654
  • https://code.djangoproject.com/ticket/34822 - Provide migration serializer for _lru_cache_wrapper

Other/Misc

• Security reports review and analysis.
• DjangoCon talk continued.

[nessita]

Week ending 2023-09-17 (Week 37)

Triaged

• https://code.djangoproject.com/ticket/34831 - Search in admin could allow issuing a query with many OR’d clauses (accepted)
• https://code.djangoproject.com/ticket/34830 - csrf_failure view missing context processors (accepted)

Reviewed

• https://github.com/django/django/pull/17219 - Fixed #34789 – Avoided filter_horizontal misbehaving when instance of same model is added via JS add action.
• https://github.com/django/django/pull/17242 - Fixed #34825 – Avoided opening nonexistent sqlite db in test worker.
• https://github.com/django/django/pull/17256 - Fixed #34822 – Added support for serializing functions decorated with functools.lru_cache in migrations.
• https://github.com/django/django/pull/16942 - Fixed #34429 – Allowed setting unusable password via admin UI.
• https://github.com/django/django/pull/17220 - Fixed #34806 – Made the cached_db backend resilient to cache backend errors.

Authored

• https://github.com/django/django/pull/17214 - Fixed #24561 – Added support for callables on model fields’ choices. (final round of tweaks after reviews and finally landed!)

Other/Misc

• Preparation for Django 5.0 feature freeze and alpha release.
• Security reports review and analysis.
• Removed spam comments from a few tickets.

[nessita]

Week ending 2023-09-24 (Week 38)

Triaged

• https://code.djangoproject.com/ticket/34853 - Accept-Language Header Takes Precedence Over Language Set With Cookie (needsinfo)
• https://code.djangoproject.com/ticket/34854 - Missing translations in pt (Portuguese) (invalid)
• https://code.djangoproject.com/ticket/34859 - Format SQL code produced by sqlmigrate (wontfix, asked for forum post)

Reviewed

• https://github.com/django/django/pull/17281 - Added updating the Django release process on Trac to release steps.
• https://github.com/django/django/pull/17284 - Fixed #34850 – Dropped support for MariaDB 10.4.
• https://github.com/django/django/pull/17219 - Fixed #34789 – Avoided filter_horizontal misbehaving when instance of same model is added via JS add action.
• https://github.com/django/django/pull/17290 - Refs #34808 – Doc’d that aggregation functions on empty groups can return None.

Authored

• https://github.com/django/django/pull/17277 - [5.0.x] Updated source translation catalogs.
• https://code.djangoproject.com/ticket/34848 - Updating translations catalog for javascript files fails with CommandError
• https://github.com/django/django/pull/17293 - Fixed #34848 – Ignored i18n_catalog.js file when building Django’s translations catalog.

Other/Misc

• Django 5.0 feature freeze is in effect, the stable/5.0.x branch was created.
• Django 5.0 alpha 1 was released!
  • https://www.djangoproject.com/weblog/2023/sep/18/django-50-alpha-1-released/
• Reviewed security reports and prepared patches.

[nessita]

Week ending 2023-10-01 (Week 39)

Triaged

• https://code.djangoproject.com/ticket/34853 - Accept-Language Header takes precedence over cookie for format localization (accepted)(invalid)
  • Deep dive and some minor tidying up to tickets/PRs related to having HTML input widgets with type="date" (https://code.djangoproject.com/ticket/33113, https://code.djangoproject.com/ticket/29822).
• https://code.djangoproject.com/ticket/25943 - Auto Generated urls.py On startapp (continued conversation based on forum post)
• https://code.djangoproject.com/ticket/34881 - migrate crashes when renaming model referenced twice by ManyToManyField.through model on SQLite. (accepted)

Reviewed

• https://github.com/django/django/pull/17312 - [4.2.x] Refs #34320 – Skipped SchemaTests.test_rename_field_with_check_to_truncated_name on MariaBD 10.5.2+.
• https://github.com/django/django/pull/17311 - Added warning about flatpages and untrusted users.
• https://github.com/django/django/pull/17318 - Fixed #34878 – Fixed AttributeErrror on reload when using TemplateSetting for FORM_RENDERER.
• https://github.com/django/django/pull/14905 - Fixed #33113 – Doc’d a forms.DateInput type=date example.
• https://github.com/django/django/pull/17324 - add urls.py to app_template (pending forum consensus)
• https://github.com/django/django/pull/15806 - Refs #29822 – Improved date, time and datetime HTML inputs (revisited the PR and followed up with relevant people)

Authored

• https://github.com/django/django/pull/17313 - Added stub release notes and release date for 4.2.6, 4.1.12, and 3.2.22.

Other/Misc

• Finalized security patches for all relevant Django versions.
• Sent prenotification and posted public announcement about the incoming security release planned for Oct 4th.
• Recorded the first practice session of my DjangoCon US presentation. I need to make it shorter or talk faster!

[nessita]

Week ending 2023-10-08 (Week 40)

Triaged

• https://code.djangoproject.com/ticket/34884 - Half bug/half enhancement : inconsistent behavior of get_or_create() regarding related attributes cache (invalid)
• https://code.djangoproject.com/ticket/34892 - Static files aren’t served correctly on dev server when DEBUG and FORCE_SCRIPT_NAME are enabled (needsinfo)

Reviewed

• https://github.com/django/django/pull/17337 - Corrected wrap_socket() reference in docs/ref/settings.txt.
• https://github.com/django/django/pull/17341 - Refs #22936 – Doc’d Lookup.prepare_rhs.
• https://github.com/django/django/pull/17283 - Refs #31435 – Doc’d potential danger of referring to model fields within init
• https://github.com/django/django/pull/17308 - Fixed #34808 – Documented aggregate default argument.

Authored

• https://forum.djangoproject.com/t/django-release-announcements/655/65

Other/Misc

• Django Security Release issued for 4.2.6, 4.1.12, 3.2.22
  • https://www.djangoproject.com/weblog/2023/oct/04/security-releases/
• Final touches to DjangoCon US presentation.

[nessita]

Week ending 2023-10-15 (Week 41)

Triaged

• https://code.djangoproject.com/ticket/34896 - First-party passkey support in django.auth
• https://code.djangoproject.com/ticket/34899 - Model Field.choices callable support is not actually lazy

Reviewed

• https://github.com/django/django/pull/17327 - Add warning about using native date inputs widgets
• https://github.com/django/django/pull/17328 - Fixes #27929 – Not removing original (non-hashed) files after processing
• https://github.com/django/django/pull/17353 - Updated Python’s references to be the official docs instead of Dive Into Python.
• https://github.com/django/django/pull/16942 - Fixed #34429 – Allowed setting unusable password via admin UI.
• https://github.com/django/django/pull/17308 - Fixed #34808 – Doc’d aggregate default argument.
• https://github.com/django/django/pull/17357 - Fixed #10743 – Allowed lookup separators in list_display

Authored

• Merged https://github.com/django/django/pull/16896 after a new round of improvements and feedback.

Other/Misc

• Replied to https://forum.djangoproject.com/t/django-db-transactions/24314, https://forum.djangoproject.com/t/updating-the-default-startapp-template/24193.
• Pinged original author of code related to https://code.djangoproject.com/ticket/34566 to gather extra feedback.
• Lots of DjangoCon US preparation
  • Travel preparation and family arrangements
  • Presentation polishing and rehearsal (Thank you @sarahboyce and @carltongibson!)

[nessita]

Week ending 2023-10-22 (Week 42)

DjangoCon US conference week!

Conference report: I arrived at noon on Sunday, very tired after 30 hours of traveling. I had a few scares with flights and connections, but in the end, it all worked out. I met A LOT of wonderful people while in Durham, both existing “digital” acquaintances and people I had never met before. Everyone was so, so friendly and welcoming, and also very supportive.

During the week, I barely opened my laptop, so the bulk of my work involved meeting the community, engaging in very interesting conversations about Django—its strengths, weaknesses, and ways to help and make it better. We also discussed inclusion, and it was quite amazing that I had to wait in line for the ladies’ bathroom (may sound trivial, but I consider this an impactful conference achievement! I’ve never had to wait in the bathroom at a tech conference before).

I was astonished by the diversity of both the speakers and attendees, not just in terms of gender but also with the presence of many other minority groups. I enjoyed and learned from all the talks, but the Djangonauts, in particular, made me feel fortunate to be a part of this community. I also engaged in other interesting but less relevant conversations, such as discussing how to prepare mate and my life before becoming a fellow.

During the sprint, I split my time between onboarding and assisting new contributors and discussing Django documentation with Daniele Procida. We reviewed several contributing-related doc pages that I had personally found challenging while preparing for my role. Daniele provided a dozen excellent suggestions that we’ll work to incorporate soon. I’d like to express my gratitude to Lance (@lancegoyke) and Velda (@VeldaKiara) for stepping up and offering to assist in this effort.

In summary, a heartfelt thank you to each and every one of you! I feel privileged to have had the opportunity to attend and share my experiences with all of you. Thanks to the organizers, volunteers, those who engaged in discussions, those who provided support before, during, and after my presentation, and all the attendees who were friendly and respectful of our code of conduct.

[carltongibson]

@nessita I’ve heard numerous positive reports on your talk. It really hit home!

[carltongibson]

@nessita

Triaged

…

For Triaged tickets, could I request an outcome in brackets at the end of the line? e.g. ticket-34896 … (wontfix)

That would be helpful

[nessita]

@carltongibson

For Triaged tickets, could I request an outcome in brackets at the end of the line? e.g. ticket-34896 … (wontfix)

Yes, absolutely! In fact I usually have those, I’ll debug what happened with the last batch. Thanks for pointing this out!

[thibaudcolas]

It was great to get to meet you at DjangoCon!

I also engaged in other interesting but less relevant conversations, such as discussing how to prepare mate and my life before becoming a fellow.

I wish I’d been around for those conversations, they seem pretty essential to me

[nessita]

Week ending 2023-10-29 (Week 43)

I started the week feeling quite exhausted after DjangoCon US and the trip back home. I thought I could ease into the week, when Mariusz luckily reminded me (thank you!!!) that “today” (that was last Monday) was Beta Release Day. After a brief moment of panic and some mate, I reviewed and merged the pending release blocker, allowing for the subsequent 5.0 Beta Release, so it all worked out in the end.

To avoid reliving such a shocking episode, I’ve created a dedicated Google Calendar for Django Releases. The main purpose of this calendar is to track both past and upcoming Django releases, as well as send (me) timely reminders to allow sufficient preparation time for release tasks. If you believe this calendar could be valuable for you personally or for the broader community, let me know!

Triaged

• https://code.djangoproject.com/ticket/34929 - Issue with Django 3.2 and Django-storage 1.14.2 after Upgrading from Django 2.2.28 (invalid)
• https://code.djangoproject.com/ticket/33230 - Test client doesn’t set explicitly provided Content-Type when data is empty (wontfix)
• https://code.djangoproject.com/ticket/34930 - Parallel tests fail on Python 3.11+ when IsolatedAsyncioTestCase is used (wontfix)

Reviewed

• https://github.com/django/django/pull/17407 - Fixed #34923 – Avoided initializing LEVEL_TAGS when importing django.contrib.messages.
• https://github.com/django/django/pull/17370 - Fixed #34899 – Added blank choice to callable choices lazily.
• https://github.com/django/django/pull/17384 - Fixed #15578 – Stated the processing order of fixtures in the fixtures docs.
• https://github.com/django/deps/pull/81 - Update DEPs 1, 10, and 12 to reflect current governance

Other/Misc

• Django 5.0 Beta Release!
  • https://www.djangoproject.com/weblog/2023/oct/23/django-50-beta-1-released/
• Reading of DEPs, proposed changes and replied to https://forum.djangoproject.com/t/updating-our-dep-process-dep-1/24783/8
• DjangoCon survey.
• Security patch review.

[nessita]

Week ending 2023-11-05 (Week 44)

Triaged

• https://code.djangoproject.com/ticket/34694 - trailing slash is not appending (worksforme)
• https://code.djangoproject.com/ticket/34940 - Filter queryset on “tuples” of values for multiple columns (duplicate)
• https://code.djangoproject.com/ticket/34941 - db_default with decimal.Decimal() doesn’t return Decimal instances on Oracle. (accepted)

Reviewed

• https://github.com/django/django/pull/17388 - Fixed #34909 – Added aria-describedby to Admin Add/Change buttons
• https://github.com/django/django/pull/11783 - Resolved #30032 – Added support for query expressions as default values
  • I ended up in this PR after reading on ticket 32577
  • I pushed a rebase, plus conflict and style fixes, and pinged the author
• https://github.com/django/django/pull/17227 - Fixed #34813 – Doc’d how calculation of the integrity HTML attr needs to occur after collectstatic.
• https://github.com/django/django/pull/17220 - Fixed #34806 – Made the cached_db backend resilient to cache backend errors.
• https://github.com/django/django/pull/17417 - Fixed #34925 – Fixed Model.refresh_from_db() skipping items in fields param.
• https://github.com/django/django/pull/17416 - Fixed #16429 – Provided refresh option for FilePathField path choices.
  • After a round of reviews, I realized that the understanding of what “automatically refresh choices” mean may differ from what others understand, so if you are interested in this work, I’d suggest reading my latest comments in the PR and sharing your view.

Authored

• https://github.com/django/django/pull/17429 - Refs #30601 – Fixed typos in docs/topics/db/transactions.txt.
• https://github.com/django/django/pull/17428 - Refs #15578 – Made cosmetic edits to fixtures docs.

Other/Misc

• Continuing on the consensus topic, I read Jacob’s suggestion Consensus Decision Making - Seeds for Change:
  • I think our consensus model definitely needs improvement as I posted last week in the forum but, from the article, we may not be “that far” from having a functional model. For example, we already have an agreement schema that maps nicely to the one in the article:
    • “Agree” would be our +1
    • “Agree with reservations” → +0
    • “Stand aside” → -0
    • “Block” → -1
  • The article also describes how the Block should be used wisely and strategically, proposing a few tools to allow “unfolding” that Block into processes that lead to an eventual consensus. I think adapting something along these lines could be key for us.
  • Lastly, I think we could use all/some of the suggested conditions for consensus, to build and document our own consensus process. Specifically, I think we already have trust and are open with each other, but I would appreciate a more clear/documented “common goal” and a more explicit “Commitment to consensus”.
• Following conversation in the forum about the User model, I watched this DjangoCon AU talk and did some readings on the links shared by Lily. I learnt a lot, thanks!
• Investigated former tickets and PRs related to ticket 34457
  • Posted +1 on makemigrations --check output regression in 4.2 - ORM - Django Forum
• Read Why is the Django Admin “Ugly”? - CodeRed

[nessita]

Week ending 2023-11-12 (Week 45)

Triaged

• https://code.djangoproject.com/ticket/34944 - Missing or misinferred attributes in output fields of generated fields (accepted)
• https://code.djangoproject.com/ticket/21183 - Filter block on the right covers information in admin (wontfix)
• https://code.djangoproject.com/ticket/34953 - CSRF verification fails even with CSRF middleware commented out (invalid)
• https://code.djangoproject.com/ticket/34962 - Support for overriding result of model field values (wontfix)
• https://code.djangoproject.com/ticket/34961 - Add a max_length parameter to EmailValidator (wontfix)
• https://code.djangoproject.com/ticket/34959 - Q(a=b) and Exact(a, b) handle NULLs differently (duplicate)
• https://code.djangoproject.com/ticket/34958 - Intermittent messages_tests.tests.TestLevelTags.test_lazy test failure (accepted)
• https://code.djangoproject.com/ticket/34963 - Recursive and other “combinator” queries broken in django-cte (invalid)

Reviewed

• https://github.com/django/django/pull/17448 - Fixed #34457 – Restored output for makemigrations --check.
• https://github.com/django/django/pull/17446 - Fixed #34946 – Preserved db_default on combined default field addition.
• https://github.com/django/django/pull/17438 - Fixed #34830 – Added request to csrf_failure view’s template context.
  • I reverted this one after a conversation with Tim Graham in the ticket.
• https://github.com/django/django/pull/17357 - Fixed #10743 – Allowed lookup separators in list_display
• https://github.com/django/django/pull/17452 - Fixed #34952 – Copied dir list when processing locale folders to avoid missing entries during os.walk traversal.

Authored

• https://github.com/django/django/pull/17462 - Fixed #34958 – Fixed isolation of messages_tests.tests.TestLevelTagstest_lazy.
  • This one was “fun” to do in that I found the experience rewarding once I solved it, but until then I spent a lot of time debugging what the heck was going on, with little success. While I did have the “shuffle seed” to reproduce the error when running the whole suite (YEY), it took me a lot of printing and runs to reduce the scope of the test run to a subset. Is there a procedure to methodically find this reduced set of troubling tests?
    (I tried --pair (probably misused) but I kept having No problem pair found )

Other/Misc

• Follow up on ticket-34830 made me go deeper in the report investigation leading to many TILs around our default (error) views and the template handling. Thanks Tim!

[adamchainz]

@nessita

Is there a procedure to methodically find this reduced set of troubling tests?

detect-test-pollution uses a bisect approach to find a pair of polluting tests. See its video tutorial for an explanation. It works with pytest but could be adapted to work with unittest/django’s test runner.

I’ve not used --pair, that’s interesting! O(n) though…

[adamchainz]

Ah no, I misunderstood --pair from its docstring. Just found the docs. It works like detect-test-pollution.

Maybe it’s not properly compatible with --shuffle? It seems like a good candidate for promotion to an actual Django feature rather than living only in runtests.py…

[nessita]

@adamchainz Thanks for the pointers!

What do you mean with promoting pair to an actual Django feature?

[Lily-Foote]

I suspect Adam means supporting it for manage.py test too.

[adamchainz]

Yes, and the bisect option!